From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60540 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ODaMD-0001Sb-Fy for qemu-devel@nongnu.org; Sun, 16 May 2010 05:42:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ODaMC-00015r-1u for qemu-devel@nongnu.org; Sun, 16 May 2010 05:42:01 -0400 Received: from mail-fx0-f45.google.com ([209.85.161.45]:46001) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ODaMB-00015n-Ra for qemu-devel@nongnu.org; Sun, 16 May 2010 05:42:00 -0400 Received: by fxm9 with SMTP id 9so2713185fxm.4 for ; Sun, 16 May 2010 02:41:59 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4BEFBDE4.6090107@redhat.com> Date: Sun, 16 May 2010 11:41:56 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <4BEE7F80.2090203@web.de> In-Reply-To: <4BEE7F80.2090203@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Put dependency files in proper subdir List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel , Juan Quintela On 05/15/2010 01:03 PM, Jan Kiszka wrote: > From: Jan Kiszka > > This seems to resolve subtle breakages of our build system: > > Dependency files generated for targets like 'dir/foo.o' were saved as > 'foo.d'. Now, if there was also a target 'foo.o', one of the dependency > file was overwritten. Concrete example: libhw*/macio.o vs. > libhw*/ide/macio.o. And this often left a segfaulting build result > behind when changing the "wrong" data structures". > > Fix it by generating proper 'dir/foo.d'. Acked-by: Paolo Bonzini Paolo