From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43902 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ODiQ6-0001Zc-8I
	for qemu-devel@nongnu.org; Sun, 16 May 2010 14:18:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1ODiBW-0001zT-F6
	for qemu-devel@nongnu.org; Sun, 16 May 2010 14:03:32 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:38905)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1ODiBW-0001zM-2a
	for qemu-devel@nongnu.org; Sun, 16 May 2010 14:03:30 -0400
Message-ID: <4BF0336D.1000000@web.de>
Date: Sun, 16 May 2010 20:03:25 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4BE93882.8050105@dlh.net>
	<m3sk5yxcde.fsf@trasno.mitica>	<4BEFDEE1.5070906@redhat.com>
	<m3iq6nc3hr.fsf@trasno.mitica>
In-Reply-To: <m3iq6nc3hr.fsf@trasno.mitica>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig5623DC4A8E62572B3ACC303D"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: Qemu-KVM Livate Migration 0.12.2 -> 0.12.3/4
	broken?
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: Peter Lieven <pl@dlh.net>, Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig5623DC4A8E62572B3ACC303D
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Juan Quintela wrote:
> Lack of "proper" subsections.  IDE is something like:
>=20
> const VMStateDescription vmstate_ide_drive =3D {
>     .version_id =3D 4,
> ....
> }
>=20
> static const VMStateDescription vmstate_bmdma =3D {
>     .name =3D "ide bmdma",
>     .version_id =3D 4,
> ...
> }
>=20
> const VMStateDescription vmstate_ide_pci =3D {
>     .name =3D "ide",
>     .version_id =3D 4,
> ....
>         VMSTATE_STRUCT_ARRAY(bmdma, PCIIDEState, 2, 0,
>                      vmstate_bmdma, BMDMAState),
>         VMSTATE_IDE_DRIVES(bus[0].ifs, PCIIDEState),
>         VMSTATE_IDE_DRIVES(bus[1].ifs, PCIIDEState),
> ....
> }
>=20
>=20
> Notice that everything is at version 4.  It used to be everything at
> version 3.  Now the problem is that when migrating from v3 -> v4.  We
> put in one place v3, But we only have a version number at the toplevel,=

> rest of "subsections" don't sent a version number.  There is no way to
> fix it in the general case.  We can hack something around for ide, but
> that will just be a hack, or we can backport marcelo change and port it=

> as a proper subsection (that is my plan).  I expect to have time at the=

> end of next time to work on this.

BTW, the IDE subsystem is yet lacking a proper vmstate section split-up
along qdev boundaries (ie. vmstate_ide_pci should not contain drive
structures). Do you plan to address this as well?

Jan


--------------enig5623DC4A8E62572B3ACC303D
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkvwM20ACgkQitSsb3rl5xS2SQCfdQ4JGg+2HTqj3o9vi6QcKJ72
LJoAn0hDvlv64+dmSoRVyV9FfCdoUFir
=BaGt
-----END PGP SIGNATURE-----

--------------enig5623DC4A8E62572B3ACC303D--