From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36620 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ODuJl-0004pr-3o
	for qemu-devel@nongnu.org; Mon, 17 May 2010 03:00:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1ODuJX-00027p-HI
	for qemu-devel@nongnu.org; Mon, 17 May 2010 03:00:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19470)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1ODuJV-00027I-9M
	for qemu-devel@nongnu.org; Mon, 17 May 2010 03:00:34 -0400
Message-ID: <4BF0E988.1040505@redhat.com>
Date: Mon, 17 May 2010 10:00:24 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4BE93882.8050105@dlh.net>
	<m3sk5yxcde.fsf@trasno.mitica>	<4BEFDEE1.5070906@redhat.com>
	<m3iq6nc3hr.fsf@trasno.mitica>	<4BF00592.5040403@redhat.com>
	<m3eihbbolj.fsf@trasno.mitica>
In-Reply-To: <m3eihbbolj.fsf@trasno.mitica>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: Qemu-KVM Livate Migration 0.12.2 -> 0.12.3/4
	broken?
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: Peter Lieven <pl@dlh.net>, qemu-devel@nongnu.org, kvm@vger.kernel.org

On 05/16/2010 11:04 PM, Juan Quintela wrote:
>
>>> So, to make the story short: I know what is happening, and I know how to
>>> fix it, just that fix is not trivial.  I just need time.
>>>
>>>        
>> Meanwhile, we have a broken 0.12.4.  Is there a quick'n'dirty
>> workaround that will be forward compatible with the real fix that we
>> can push out?
>>      
> revert the patch.  It almost never happen (being in the middle of one
> IO) while migrating.
>    

If the guest does any work, it will always happen.

>    
>> We've regressed from failing some migrations to failing all migrations.
>>      
> Humm, 0.12.4 ->  0.12.4 should work.  My advise is just revert the patch
> and live with it for another week, what do you think?
>    

A week is fine.  I'm not going to release 0.12.4.1 for the week until 
you fix it, and just changing things in git doesn't help users.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.