From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41152 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ODwLQ-0000fM-MI for qemu-devel@nongnu.org; Mon, 17 May 2010 05:10:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ODwLB-0005bg-42 for qemu-devel@nongnu.org; Mon, 17 May 2010 05:10:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18595) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ODwLA-0005bX-R2 for qemu-devel@nongnu.org; Mon, 17 May 2010 05:10:25 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4H9AODl029410 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 17 May 2010 05:10:24 -0400 Message-ID: <4BF107EB.7040709@redhat.com> Date: Mon, 17 May 2010 11:10:03 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1274011197-26196-1-git-send-email-avi@redhat.com> In-Reply-To: <1274011197-26196-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] block: fix aio_flush segfaults for read-only protocols (e.g. curl) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org Am 16.05.2010 13:59, schrieb Avi Kivity: > Not all block format drivers expose an io_flush method (reasonable for > read-only protocols), so calling io_flush there will immediately segfault. > > Fix by checking for the method's existence before calling it. > > Signed-off-by: Avi Kivity Thanks, applied to the block branch. Kevin