From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33564 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ODxxN-0002XP-8l
	for qemu-devel@nongnu.org; Mon, 17 May 2010 06:53:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1ODxxL-0002vg-PY
	for qemu-devel@nongnu.org; Mon, 17 May 2010 06:53:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58176)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1ODxxL-0002vN-Hw
	for qemu-devel@nongnu.org; Mon, 17 May 2010 06:53:55 -0400
Message-ID: <4BF12038.3010600@redhat.com>
Date: Mon, 17 May 2010 12:53:44 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Add QEMU DirectFB display driver
References: <1273856330-15161-1-git-send-email-julian.pidancet@citrix.com>
In-Reply-To: <1273856330-15161-1-git-send-email-julian.pidancet@citrix.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Julian Pidancet <julian.pidancet@citrix.com>
Cc: qemu-devel@nongnu.org

> +directfb="no"

Should be ="" (aka autodetect).

> +if test "$directfb" = "yes" ; then
> +  directfb_libs=`directfb-config --libs`
> +  directfb_cflags=`directfb-config --cflags`
> +  libs_softmmu="$directfb_libs $libs_softmmu"
> +fi

use pkgconfig here.  directfb-config most likely is just a pkgconfig 
wrapper anyway.

cheeers,
   Gerd