From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49765 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ODz3H-0001kQ-VV for qemu-devel@nongnu.org; Mon, 17 May 2010 08:04:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ODz3A-0005XA-3D for qemu-devel@nongnu.org; Mon, 17 May 2010 08:04:07 -0400 Received: from smtp.citrix.com ([66.165.176.89]:26870) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ODz38-0005Wj-Jp for qemu-devel@nongnu.org; Mon, 17 May 2010 08:03:58 -0400 Message-ID: <4BF130BA.6050903@citrix.com> Date: Mon, 17 May 2010 13:04:10 +0100 From: Julian Pidancet MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Add QEMU DirectFB display driver References: <1273856330-15161-1-git-send-email-julian.pidancet@citrix.com> <4BF12038.3010600@redhat.com> In-Reply-To: <4BF12038.3010600@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: "qemu-devel@nongnu.org" On 05/17/2010 11:53 AM, Gerd Hoffmann wrote: >> +directfb="no" > > Should be ="" (aka autodetect). > >> +if test "$directfb" = "yes" ; then >> + directfb_libs=`directfb-config --libs` >> + directfb_cflags=`directfb-config --cflags` >> + libs_softmmu="$directfb_libs $libs_softmmu" >> +fi > > use pkgconfig here. directfb-config most likely is just a pkgconfig > wrapper anyway. > Unfortunately, directfb-config is not a pkgconfig wrapper, it is a standalone shell script. Thus, I don't know if there is an easier way of "autodetecting" directfb than probing the directfb-config script. -- Julian