From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42814 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OE56M-0005M4-9t for qemu-devel@nongnu.org; Mon, 17 May 2010 14:31:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OE56K-0001dQ-Sf for qemu-devel@nongnu.org; Mon, 17 May 2010 14:31:42 -0400 Received: from are.twiddle.net ([75.149.56.221]:48576) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OE56K-0001dJ-M1 for qemu-devel@nongnu.org; Mon, 17 May 2010 14:31:40 -0400 Received: from anchor.twiddle.home (anchor.twiddle.home [172.31.0.4]) by are.twiddle.net (Postfix) with ESMTPSA id B515E47 for ; Mon, 17 May 2010 11:31:39 -0700 (PDT) Message-ID: <4BF18B8B.4000706@twiddle.net> Date: Mon, 17 May 2010 11:31:39 -0700 From: Richard Henderson MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/2] two tcg improvements References: <1272929448-4223-1-git-send-email-rth@twiddle.net> In-Reply-To: <1272929448-4223-1-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Ping? Update: The TYPE parameter to tcg_out_mov would be helpful for the S390 port as well. The 32-bit LR is 2 bytes, while the 64-bit LGR is 4 bytes. r~ On 05/03/2010 04:30 PM, Richard Henderson wrote: > The first patch allows the x86-64 port to avoid the REX.W prefix > on moves, by allowing reg-reg moves to be typed just as reg-imm > moves already are. This does require trivial changes to each port. > > The second patch fixes an oversight in commit > 86feb1c860dc38e9c89e787c5210e8191800385e > whereby I only modified the 32-bit host versions of the inline > functions and not the 64-bit host versions. This is visible on > x86-64 host with arm guest in that we unnecessarily emit some > MOVSLQ insns instead of plain 32-bit MOV insns. > > > r~ > > > > Richard Henderson (2): > tcg: Add TYPE parameter to tcg_out_mov. > tcg: Use INDEX_op_qemu_ld32 for 32-bit results. > > tcg/arm/tcg-target.c | 2 +- > tcg/hppa/tcg-target.c | 38 ++++++++++++++++++------------------ > tcg/i386/tcg-target.c | 49 ++++++++++++++++++++++++----------------------- > tcg/ia64/tcg-target.c | 3 +- > tcg/mips/tcg-target.c | 28 +++++++++++++------------- > tcg/ppc/tcg-target.c | 48 +++++++++++++++++++++++----------------------- > tcg/ppc64/tcg-target.c | 10 ++++---- > tcg/s390/tcg-target.c | 2 +- > tcg/sparc/tcg-target.c | 10 ++++---- > tcg/tcg-op.h | 8 +++++++ > tcg/tcg.c | 12 +++++----- > tcg/x86_64/tcg-target.c | 20 ++++++++++-------- > 12 files changed, 121 insertions(+), 109 deletions(-) > > >