From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50123 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OE5wR-00009t-Bf
	for qemu-devel@nongnu.org; Mon, 17 May 2010 15:25:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OE5wL-00012p-Ew
	for qemu-devel@nongnu.org; Mon, 17 May 2010 15:25:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47152)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OE5wL-00012d-3z
	for qemu-devel@nongnu.org; Mon, 17 May 2010 15:25:25 -0400
Message-ID: <4BF1981E.5080603@redhat.com>
Date: Mon, 17 May 2010 21:25:18 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Add QEMU DirectFB display driver
References: <1273856330-15161-1-git-send-email-julian.pidancet@citrix.com>
	<4BF12038.3010600@redhat.com> <4BF130BA.6050903@citrix.com>
In-Reply-To: <4BF130BA.6050903@citrix.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Julian Pidancet <julian.pidancet@citrix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 05/17/10 14:04, Julian Pidancet wrote:
> On 05/17/2010 11:53 AM, Gerd Hoffmann wrote:
>>> +directfb="no"
>>
>> Should be ="" (aka autodetect).
>>
>
>
>
>>> +if test "$directfb" = "yes" ; then
>>> +  directfb_libs=`directfb-config --libs`
>>> +  directfb_cflags=`directfb-config --cflags`
>>> +  libs_softmmu="$directfb_libs $libs_softmmu"
>>> +fi
>>
>> use pkgconfig here.  directfb-config most likely is just a pkgconfig
>> wrapper anyway.
>>
>
> Unfortunately, directfb-config is not a pkgconfig wrapper, it is a standalone shell script.
> Thus, I don't know if there is an easier way of "autodetecting" directfb than probing the directfb-config script.
>

'pkg-config directfb'
	exit code 0 => success
	exit code 1 => failure

pkg-config --cflags directfb
	finds cflags

Check 'pkg-config --help' && man page for more info.

Oh, and btw: the patch doesn't build when applied to latest master bits.

HTH,
   Gerd