From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33978 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OEKkd-0008QZ-BT for qemu-devel@nongnu.org; Tue, 18 May 2010 07:14:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OEKkW-0004CY-TX for qemu-devel@nongnu.org; Tue, 18 May 2010 07:14:19 -0400 Received: from zion.dlh.net ([91.198.192.1]:58271 helo=mail.dlh.net) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OEKkW-0004CK-No for qemu-devel@nongnu.org; Tue, 18 May 2010 07:14:12 -0400 Message-ID: <4BF27676.5000606@dlh.net> Date: Tue, 18 May 2010 13:13:58 +0200 From: Peter Lieven MIME-Version: 1.0 Subject: Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion References: <4BDF3F94.1080608@dlh.net> <4BDFDC44.9030808@redhat.com> <4BE00750.6040804@dlh.net> <4BE01120.30608@redhat.com> <4BE02440.6010802@dlh.net> <4BE028BF.1000603@redhat.com> <20100504170706.GA21339@lst.de> In-Reply-To: <20100504170706.GA21339@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: Kevin Wolf , qemu-devel@nongnu.org, kvm@vger.kernel.org hi, will this patch make it into 0.12.4.1 ? br, peter Christoph Hellwig wrote: > On Tue, May 04, 2010 at 04:01:35PM +0200, Kevin Wolf wrote: > >> Great, I'm going to submit it as a proper patch then. >> >> Christoph, by now I'm pretty sure it's right, but can you have another >> look if this is correct, anyway? >> > > It looks correct to me - we really shouldn't update the the fields > until bdrv_aio_cancel has returned. In fact we cannot cancel a request > more often than we can, so there's a fairly high chance it will > complete. > > > Reviewed-by: Christoph Hellwig > > -- Mit freundlichen Grüßen/Kind Regards Peter Lieven .......................................................................................................... KAMP Netzwerkdienste GmbH Vestische Str. 89-91 | 46117 Oberhausen Tel: +49 (0) 208.89 402-50 | Fax: +49 (0) 208.89 402-40 mailto:pl@kamp.de | http://www.kamp.de Geschäftsführer: Heiner Lante | Michael Lante Amtsgericht Duisburg | HRB Nr. 12154 USt-Id-Nr.: DE 120607556 .........................................................................................................