From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Juan Quintela <quintela@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/8] qdev: Allow device addressing via 'driver.instance'
Date: Tue, 18 May 2010 14:31:56 +0200 [thread overview]
Message-ID: <4BF288BC.40409@redhat.com> (raw)
In-Reply-To: <m3r5l9mmne.fsf@blackfin.pond.sub.org>
On 05/18/10 14:15, Markus Armbruster wrote:
> Jan Kiszka<jan.kiszka@siemens.com> writes:
>
>> Extend qbus_find_dev to allow addressing of devices without an unique id
>> via an optional instance number. The new formats are 'driver.instance'
>> and 'alias.instance'.
>>
>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>
> How's the instance number defined? Should be documented.
savevm instance id, used to identify multiple instances of some device
on loadvm. By default is just incrementing (0,1,2,...) for each new
device instance I think. Drivers can also specify one. Most don't do
that. IIRC some ISA drivers use the base ioport as instance id, which
sort-of makes sense as it makes sure the id identifies the correct
device no matter what the initialization order is.
It probably makes sense to replace the instance id with the device path
once all devices are converted over to qdev+vmstate, so we avoid the
nasty ordering issues altogether.
cheers,
Gerd
next prev parent reply other threads:[~2010-05-18 12:32 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 13:20 [Qemu-devel] [PATCH 0/8] Basic device state visualization Jan Kiszka
2010-05-14 13:20 ` [Qemu-devel] [PATCH 1/8] qdev: Allow device addressing via 'driver.instance' Jan Kiszka
2010-05-18 12:15 ` Markus Armbruster
2010-05-18 12:31 ` Gerd Hoffmann [this message]
2010-05-18 12:38 ` [Qemu-devel] " Juan Quintela
2010-05-18 13:06 ` Gerd Hoffmann
2010-05-18 16:54 ` Jan Kiszka
2010-05-19 8:29 ` [Qemu-devel] " Avi Kivity
2010-05-14 13:20 ` [Qemu-devel] [PATCH 2/8] Add base64 encoder/decoder Jan Kiszka
2010-05-14 13:20 ` [Qemu-devel] [PATCH 3/8] Add QBuffer Jan Kiszka
2010-05-14 18:15 ` Anthony Liguori
2010-05-15 8:45 ` [Qemu-devel] " Jan Kiszka
2010-05-15 8:49 ` Avi Kivity
2010-05-15 8:59 ` Jan Kiszka
2010-05-15 17:31 ` Avi Kivity
2010-05-16 9:37 ` Paolo Bonzini
2010-05-16 9:50 ` Avi Kivity
2010-05-16 10:15 ` Jan Kiszka
2010-05-16 10:16 ` Paolo Bonzini
2010-05-16 10:49 ` Avi Kivity
2010-05-16 10:04 ` Jan Kiszka
2010-05-16 17:38 ` [Qemu-devel] " Jamie Lokier
2010-05-16 18:03 ` [Qemu-devel] " Jan Kiszka
2010-05-17 20:20 ` Jamie Lokier
2010-05-17 0:12 ` [Qemu-devel] " Anthony Liguori
2010-05-17 6:48 ` Avi Kivity
2010-05-17 7:40 ` [Qemu-devel] " Jan Kiszka
2010-05-17 7:45 ` Avi Kivity
2010-05-17 7:57 ` Jan Kiszka
2010-05-17 8:10 ` Avi Kivity
2010-05-17 8:13 ` Avi Kivity
2010-05-17 8:55 ` Jan Kiszka
2010-05-17 8:59 ` Avi Kivity
2010-05-17 9:17 ` Jan Kiszka
2010-05-17 9:29 ` Avi Kivity
2010-05-18 12:27 ` Markus Armbruster
2010-05-18 17:24 ` Avi Kivity
2010-05-17 13:05 ` Anthony Liguori
2010-05-18 12:28 ` Markus Armbruster
2010-05-14 13:20 ` [Qemu-devel] [PATCH 4/8] monitor: Add basic device state visualization Jan Kiszka
2010-05-18 12:12 ` Markus Armbruster
2010-05-18 17:09 ` [Qemu-devel] " Jan Kiszka
2010-05-14 13:20 ` [Qemu-devel] [PATCH 5/8] qmp: Teach basic capability negotiation to python example Jan Kiszka
2010-05-14 13:20 ` [Qemu-devel] [PATCH 6/8] qmp: Fix python helper /wrt long return strings Jan Kiszka
2010-05-14 13:20 ` [Qemu-devel] [PATCH 7/8] Add QLIST_INSERT_TAIL Jan Kiszka
2010-05-16 9:38 ` [Qemu-devel] " Paolo Bonzini
2010-05-16 10:16 ` Jan Kiszka
2010-05-14 13:20 ` [Qemu-devel] [PATCH 8/8] qdev: Add new devices/buses at the tail Jan Kiszka
2010-05-14 16:12 ` [Qemu-devel] Re: [PATCH 0/8] Basic device state visualization Avi Kivity
2010-05-14 16:24 ` Jan Kiszka
2010-05-14 16:38 ` Avi Kivity
2010-05-14 18:16 ` [Qemu-devel] " Anthony Liguori
2010-05-14 18:50 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF288BC.40409@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).