From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48075 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OEMBC-0001LM-4L
	for qemu-devel@nongnu.org; Tue, 18 May 2010 08:45:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OEMBA-0006hk-8E
	for qemu-devel@nongnu.org; Tue, 18 May 2010 08:45:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14239)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OEMB9-0006hR-Qd
	for qemu-devel@nongnu.org; Tue, 18 May 2010 08:45:48 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4ICjjNe007923
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 18 May 2010 08:45:45 -0400
Message-ID: <4BF28BF4.4070602@redhat.com>
Date: Tue, 18 May 2010 14:45:40 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2] all vga: fail graicefully when vga ports
	are taken
References: <1273610601-12805-1-git-send-email-kraxel@redhat.com>	<1273610601-12805-2-git-send-email-kraxel@redhat.com>
	<m3sk5pl787.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3sk5pl787.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On 05/18/10 14:33, Markus Armbruster wrote:
> Gerd Hoffmann<kraxel@redhat.com>  writes:
>
>> Try to pci hotplug a vga card, watch qemu die with hw_error().
>> This patch fixes it.
>
> Looks good.
>
> Are there any other hot-pluggable devices that acquire single-use
> resources such as fixed I/O ports?

Any PCI device doing ISA compatibility stuff I'd guess, which makes IDE 
a candidate.  Checking ...

Yes (hw/ide/piix.c):

     ide_init_ioport(&d->bus[0], 0x1f0, 0x3f6);
     ide_init_ioport(&d->bus[1], 0x170, 0x376);

Those are tagged with "no-user" though due to being hard-coded in pc.c, 
so any attempt to hot-plug one of those should fail way before it 
attempts to grab the I/O ports.

cheers,
   Gerd