From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47847 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OEMVQ-0004pf-BQ
	for qemu-devel@nongnu.org; Tue, 18 May 2010 09:06:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OEMVN-0002Ek-RA
	for qemu-devel@nongnu.org; Tue, 18 May 2010 09:06:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58309)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OEMVN-0002EM-Jn
	for qemu-devel@nongnu.org; Tue, 18 May 2010 09:06:41 -0400
Message-ID: <4BF290D8.3080306@redhat.com>
Date: Tue, 18 May 2010 15:06:32 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1273843151.git.jan.kiszka@siemens.com>	<cover.1273843151.git.jan.kiszka@siemens.com>	<913f4f6a67305a72ed3d994bd12d5b34de9b9bb9.1273843151.git.jan.kiszka@siemens.com>	<m3r5l9mmne.fsf@blackfin.pond.sub.org>
	<4BF288BC.40409@redhat.com> <m38w7h4c6e.fsf@trasno.mitica>
In-Reply-To: <m38w7h4c6e.fsf@trasno.mitica>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/8] qdev: Allow device addressing
	via	'driver.instance'
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Avi Kivity <avi@redhat.com>

   Hi,

> Agreed.  The problem here is that we sent the instance_id on the wire,
> so for "legacy" devices that used an instance_id != -1, we are stuck
> with it :(

Another way would be to fill the instance id with something useful, say 
encode the pci address there for pci devices.  That should be good 
enough to reliably identify devices even after hot-plugging them in and out.

Of course this has transition isses too.  But maybe it is easier to 
handle than replacing instance_id with something entirely different.

And it also makes the instance id less useful to address devices in a 
human-friendly way.

cheers,
   Gerd