From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42997 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OENFK-0006Z6-Sv
	for qemu-devel@nongnu.org; Tue, 18 May 2010 09:54:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1OENFJ-00025Q-Gx
	for qemu-devel@nongnu.org; Tue, 18 May 2010 09:54:10 -0400
Received: from e7.ny.us.ibm.com ([32.97.182.137]:37538)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1OENFF-00024n-PY
	for qemu-devel@nongnu.org; Tue, 18 May 2010 09:54:09 -0400
Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233])
	by e7.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id o4IDhVdh001000
	for <qemu-devel@nongnu.org>; Tue, 18 May 2010 09:43:31 -0400
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o4IDs4wv144312
	for <qemu-devel@nongnu.org>; Tue, 18 May 2010 09:54:04 -0400
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id
	o4IDs37K019931
	for <qemu-devel@nongnu.org>; Tue, 18 May 2010 10:54:03 -0300
Message-ID: <4BF29BF8.9020304@linux.vnet.ibm.com>
Date: Tue, 18 May 2010 08:54:00 -0500
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1274186986-26878-1-git-send-email-corentincj@iksaif.net>
	<1274186986-26878-6-git-send-email-corentincj@iksaif.net>
	<4BF29AEE.8070602@suse.de>
In-Reply-To: <4BF29AEE.8070602@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 05/10] vnc: add basic tight support
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Corentin Chary <corentincj@iksaif.net>, qemu-devel@nongnu.org, Adam Litke <agl@us.ibm.com>

On 05/18/2010 08:49 AM, Alexander Graf wrote:
>> diff --git a/vnc.h b/vnc.h
>> index 96f3fe7..ec7f481 100644
>> --- a/vnc.h
>> +++ b/vnc.h
>> @@ -166,6 +166,12 @@ struct VncState
>>       /* Tight */
>>       uint8_t tight_quality;
>>       uint8_t tight_compression;
>> +    uint8_t tight_pixel24;
>> +    Buffer tight;
>> +    Buffer tight_tmp;
>> +    Buffer tight_zlib;
>> +    int tight_levels[4];
>> +    z_stream tight_stream[4];
>>
>>      
> You just shrunk down things to a single stream for zlib, so why go with
> 4 here? Did I miss anything?
>    

Tight requires 4 streams.

Regards,

Anthony Liguori

> Alex
>
>