From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43241 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OENGp-0007rT-1P for qemu-devel@nongnu.org; Tue, 18 May 2010 09:55:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OENGm-0002K9-QA for qemu-devel@nongnu.org; Tue, 18 May 2010 09:55:42 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:47530) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OENGm-0002K3-K4 for qemu-devel@nongnu.org; Tue, 18 May 2010 09:55:40 -0400 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by e3.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id o4IDgkZM014089 for ; Tue, 18 May 2010 09:42:46 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o4IDtdCq148236 for ; Tue, 18 May 2010 09:55:39 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o4IDtdn2028121 for ; Tue, 18 May 2010 10:55:39 -0300 Message-ID: <4BF29C59.4070101@linux.vnet.ibm.com> Date: Tue, 18 May 2010 08:55:37 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1274186986-26878-1-git-send-email-corentincj@iksaif.net> <1274186986-26878-4-git-send-email-corentincj@iksaif.net> <4BF28D5F.5010404@suse.de> <4BF2987F.4070609@linux.vnet.ibm.com> <4BF29BB5.5020101@suse.de> In-Reply-To: <4BF29BB5.5020101@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2 03/10] vnc: only use a single zlib stream List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Corentin Chary , qemu-devel@nongnu.org, Adam Litke On 05/18/2010 08:52 AM, Alexander Graf wrote: > Anthony Liguori wrote: > >> On 05/18/2010 07:51 AM, Alexander Graf wrote: >> >>> Corentin Chary wrote: >>> >>> >>>> According to http://tigervnc.org/cgi-bin/rfbproto#zlib-encoding >>>> zlib encoding only uses a single stream. Current implementation defines >>>> 4 streams but only uses the first one. Remove them and only use a >>>> single >>>> stream. >>>> >>>> >>>> >>> How about when we start to implement zrle or zhextile? Wouldn't those >>> need different streams? >>> >>> >> Only tight uses multiple streams. zrle just uses one. >> > Ah, that's why I put it in there back then. I see :). > Keep in mind, tight's 4 streams are not the same as zrle or zlib's 1 stream. A server is free to send both Tight updates and zrle updates if the client supports it. The client is going to expect that zrle is a different compression stream than any of the 4 tight streams. That's why you can't use the Tight compression level selection messages to choose the zlib compression level btw. Regards, Anthony Liguori > Alex > >