From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43382 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OENHw-0008VS-RM
	for qemu-devel@nongnu.org; Tue, 18 May 2010 09:56:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <agraf@suse.de>) id 1OENHu-0002Uz-Nt
	for qemu-devel@nongnu.org; Tue, 18 May 2010 09:56:52 -0400
Received: from cantor2.suse.de ([195.135.220.15]:43096 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <agraf@suse.de>) id 1OENHu-0002Ur-IC
	for qemu-devel@nongnu.org; Tue, 18 May 2010 09:56:50 -0400
Message-ID: <4BF29CA1.30203@suse.de>
Date: Tue, 18 May 2010 15:56:49 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1274186986-26878-1-git-send-email-corentincj@iksaif.net>
	<1274186986-26878-4-git-send-email-corentincj@iksaif.net>
	<4BF28D5F.5010404@suse.de> <4BF2987F.4070609@linux.vnet.ibm.com>
	<4BF29BB5.5020101@suse.de> <4BF29C59.4070101@linux.vnet.ibm.com>
In-Reply-To: <4BF29C59.4070101@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 03/10] vnc: only use a single zlib stream
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@linux.vnet.ibm.com>
Cc: Corentin Chary <corentincj@iksaif.net>, qemu-devel@nongnu.org, Adam Litke <agl@us.ibm.com>

Anthony Liguori wrote:
> On 05/18/2010 08:52 AM, Alexander Graf wrote:
>> Anthony Liguori wrote:
>>   
>>> On 05/18/2010 07:51 AM, Alexander Graf wrote:
>>>     
>>>> Corentin Chary wrote:
>>>>
>>>>       
>>>>> According to http://tigervnc.org/cgi-bin/rfbproto#zlib-encoding
>>>>> zlib encoding only uses a single stream. Current implementation
>>>>> defines
>>>>> 4 streams but only uses the first one. Remove them and only use a
>>>>> single
>>>>> stream.
>>>>>
>>>>>
>>>>>          
>>>> How about when we start to implement zrle or zhextile? Wouldn't those
>>>> need different streams?
>>>>
>>>>        
>>> Only tight uses multiple streams.  zrle just uses one.
>>>      
>> Ah, that's why I put it in there back then. I see :).
>>    
>
> Keep in mind, tight's 4 streams are not the same as zrle or zlib's 1
> stream.  A server is free to send both Tight updates and zrle updates
> if the client supports it.  The client is going to expect that zrle is
> a different compression stream than any of the 4 tight streams.
>
> That's why you can't use the Tight compression level selection
> messages to choose the zlib compression level btw.

So patch 4 is invalid?

Alex