qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>
Subject: [Qemu-devel] Re: [PATCH +stable] block: don't attempt to merge overlapping requests
Date: Wed, 19 May 2010 11:09:07 +0300	[thread overview]
Message-ID: <4BF39CA3.9020305@redhat.com> (raw)
In-Reply-To: <AANLkTilrq4KanGzUrMZFHzYIgtncUOj24dqMi_eyLdgb@mail.gmail.com>

On 05/18/2010 10:22 PM, Stefan Hajnoczi wrote:
> On Tue, May 18, 2010 at 6:18 PM, Avi Kivity<avi@redhat.com>  wrote:
>    
>> The block multiwrite code pretends to be able to merge overlapping requests,
>> but doesn't do so in fact.  This leads to I/O errors (for example on mkfs
>> of a large virtio disk).
>>      
> Are overlapping write requests correct guest behavior?  I thought the
> ordering semantics require a flush between overlapping writes to
> ensure A is written before B.
>
> What cache= mode are you running?
>    

writeback.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

  parent reply	other threads:[~2010-05-19  8:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-18 17:18 [Qemu-devel] [PATCH +stable] block: don't attempt to merge overlapping requests Avi Kivity
2010-05-18 19:22 ` [Qemu-devel] " Stefan Hajnoczi
2010-05-18 19:37   ` Stefan Hajnoczi
2010-05-18 19:41     ` Michael Tokarev
2010-05-18 20:19       ` Stefan Hajnoczi
2010-05-19  8:09   ` Avi Kivity [this message]
2010-05-19  9:01     ` Stefan Hajnoczi
2010-05-19  9:06       ` Avi Kivity
2010-05-19  9:23         ` Stefan Hajnoczi
2010-05-19  9:31           ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF39CA3.9020305@redhat.com \
    --to=avi@redhat.com \
    --cc=hch@lst.de \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).