From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47763 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OEhZR-0002Hu-3D
	for qemu-devel@nongnu.org; Wed, 19 May 2010 07:36:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OEhRo-0001OE-6S
	for qemu-devel@nongnu.org; Wed, 19 May 2010 07:28:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54970)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OEhRn-0001NH-PU
	for qemu-devel@nongnu.org; Wed, 19 May 2010 07:28:24 -0400
Message-ID: <4BF3CB3B.1030703@redhat.com>
Date: Wed, 19 May 2010 13:27:55 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: fix barrier support
References: <20100519104009.GA8813@lst.de>
In-Reply-To: <20100519104009.GA8813@lst.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org

Am 19.05.2010 12:40, schrieb Christoph Hellwig:
> Before issuing the barrier to the block driver we need to flush our oustanding
> queue of write requests, as the flush is supposed to be issued after them.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Thanks, applied to the block branch.

I'm going to send a pull request today to get this in ASAP. It would be
helpful to know by then why Avi's patch helps and if it should be
pushed, too. It looks merely like a workaround, so I'd love to see it
replaced by a real fix.

Kevin