From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46488 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OEod9-0007TJ-HS for qemu-devel@nongnu.org; Wed, 19 May 2010 15:08:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OEod7-000843-QW for qemu-devel@nongnu.org; Wed, 19 May 2010 15:08:35 -0400 Received: from mail-pv0-f173.google.com ([74.125.83.173]:56169) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OEod7-00083p-Kn for qemu-devel@nongnu.org; Wed, 19 May 2010 15:08:33 -0400 Received: by pvg6 with SMTP id 6so1398590pvg.4 for ; Wed, 19 May 2010 12:08:32 -0700 (PDT) Message-ID: <4BF4372C.7060000@codemonkey.ws> Date: Wed, 19 May 2010 14:08:28 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions. References: <1273063904-6028-1-git-send-email-kraxel@redhat.com> <1273063904-6028-2-git-send-email-kraxel@redhat.com> <4BE3BBA1.3010007@redhat.com> <4BF39E72.6070906@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Paolo Bonzini , Gerd Hoffmann , qemu-devel@nongnu.org On 05/19/2010 01:57 PM, Blue Swirl wrote: > On 5/19/10, Gerd Hoffmann wrote: > >>> >>>> >>>>> Then there would be no need of parsing. >>>>> >>>>> >>>> You would need _two_ bitmaps (e.g. mask and cursor, so that mask=1 >>>> >> gives >> >>>> transparent, mask=0 cursor=0 gives black and mask=0 cursor=1 gives >>>> >> white). >> >>>> >>> Yes, but it's still packed more efficiently. >>> >>> >> Well. You can't have both. We can have a efficiently packed format (i.e. >> two bitmaps). Or we can do it in a way which doesn't need parsing, but that >> wouldn't be the most compact format ... >> > You're right, so packing or introducing a small conversion function is > not critical. I'd still prefer a standard format if possible. > Personally, I'd rather see Gerd's original format but read from a file instead of hard coded in a .c file. IOW, a /usr/share/qemu/default-cursor.qpm that contained the appropriate strings. A couple extra lines that made it an xpm I think would be worth it too. Regards, Anthony Liguori >>> There's yet another way: >>> #define _ 0, >>> #define X 0xff000000, >>> #define o 0xffffffff, >>> { >>> _ _ _ X o X _ _ _ >>> } >>> #undef _ >>> #undef X >>> #undef o >>> >>> >> Neat idea ;) >> >> cheers, >> Gerd >> >> >> >