qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/6] json-lexer: Handle missing escapes
Date: Wed, 19 May 2010 16:44:47 -0500	[thread overview]
Message-ID: <4BF45BCF.5090300@codemonkey.ws> (raw)
In-Reply-To: <1274303733-3700-3-git-send-email-lcapitulino@redhat.com>

On 05/19/2010 04:15 PM, Luiz Capitulino wrote:
> The JSON escape sequence "\/" and "\\" are valid and should be
> handled.
>
> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
>    

Good catch.

> ---
>   json-lexer.c |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/json-lexer.c b/json-lexer.c
> index 0b145d1..5cc7e6c 100644
> --- a/json-lexer.c
> +++ b/json-lexer.c
> @@ -97,6 +97,8 @@ static const uint8_t json_lexer[][256] =  {
>           ['n'] =  IN_DQ_STRING,
>           ['r'] =  IN_DQ_STRING,
>           ['t'] =  IN_DQ_STRING,
> +        ['/'] = IN_DQ_STRING,
> +        ['\\'] = IN_DQ_STRING,
>           ['\''] = IN_DQ_STRING,
>           ['\"'] = IN_DQ_STRING,
>           ['u'] = IN_DQ_UCODE0,
> @@ -134,6 +136,8 @@ static const uint8_t json_lexer[][256] =  {
>           ['n'] =  IN_SQ_STRING,
>           ['r'] =  IN_SQ_STRING,
>           ['t'] =  IN_SQ_STRING,
> +        ['/'] = IN_DQ_STRING,
> +        ['\\'] = IN_DQ_STRING,
>           ['\''] = IN_SQ_STRING,
>           ['\"'] = IN_SQ_STRING,
>           ['u'] = IN_SQ_UCODE0,
>    

  reply	other threads:[~2010-05-19 21:50 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19 21:15 [Qemu-devel] [PATCH 0/6]: QMP: Fix issues in parser/lexer Luiz Capitulino
2010-05-19 21:15 ` [Qemu-devel] [PATCH 1/6] json-lexer: Initialize 'x' and 'y' Luiz Capitulino
2010-05-19 21:15 ` [Qemu-devel] [PATCH 2/6] json-lexer: Handle missing escapes Luiz Capitulino
2010-05-19 21:44   ` Anthony Liguori [this message]
2010-05-20 13:44     ` Luiz Capitulino
2010-05-20 15:16       ` [Qemu-devel] " Paolo Bonzini
2010-05-20 15:25         ` Luiz Capitulino
2010-05-20 15:26           ` Paolo Bonzini
2010-05-20 15:35             ` Luiz Capitulino
2010-05-20 15:54               ` Anthony Liguori
2010-05-20 16:27                 ` Luiz Capitulino
2010-05-20 15:50         ` Anthony Liguori
2010-05-20 16:27           ` Luiz Capitulino
2010-05-20 16:55             ` Anthony Liguori
2010-05-20 18:47               ` Luiz Capitulino
2010-05-20 18:52                 ` Anthony Liguori
2010-05-20 19:22                   ` Luiz Capitulino
2010-05-24 19:29                     ` Anthony Liguori
2010-05-24 19:38                       ` Luiz Capitulino
2010-05-19 21:15 ` [Qemu-devel] [PATCH 3/6] qjson: Handle "\f" Luiz Capitulino
2010-05-19 21:15 ` [Qemu-devel] [PATCH 4/6] check-qjson: Add more escape tests Luiz Capitulino
2010-05-19 21:15 ` [Qemu-devel] [PATCH 5/6] json-lexer: Drop 'buf' Luiz Capitulino
2010-05-19 21:15 ` [Qemu-devel] [PATCH 6/6] json-streamer: Don't use qdict_put_obj() Luiz Capitulino
2010-05-19 21:43 ` [Qemu-devel] [PATCH 0/6]: QMP: Fix issues in parser/lexer Anthony Liguori
2010-05-20 13:35   ` Luiz Capitulino
2010-05-21 18:06     ` Luiz Capitulino
2010-05-20 15:18   ` [Qemu-devel] " Paolo Bonzini
2010-05-20 15:26     ` Luiz Capitulino
2010-05-20 15:52     ` Anthony Liguori
2010-05-20 16:29       ` Luiz Capitulino
2010-05-21  9:08       ` [Qemu-devel] [PATCH] do not require lookahead in json-lexer.c if not necessary Paolo Bonzini
2010-05-21 10:10         ` [Qemu-devel] [PATCH] do not require lookahead for escapes too Paolo Bonzini
2010-05-23  7:50           ` [Qemu-devel] " Paolo Bonzini
2010-05-20 19:49   ` [Qemu-devel] [PATCH 0/6]: QMP: Fix issues in parser/lexer Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF45BCF.5090300@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=aliguori@us.ibm.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).