* [Qemu-devel] [PATCH] block: Fix compilation with DEBUG defined
@ 2010-05-19 20:53 Riccardo Magliocchetti
2010-05-20 8:43 ` [Qemu-devel] " Kevin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: Riccardo Magliocchetti @ 2010-05-19 20:53 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Riccardo Magliocchetti
gcc does not like passing a NULL where an int value is expected:
block/vvfat.c: In function ‘checkpoint’:
block/vvfat.c:2868: error: passing argument 2 of ‘remove_mapping’ makes
integer from pointer without a cast
Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
---
block/vvfat.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index ce16bbd..13c31fa 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2865,7 +2865,7 @@ static void checkpoint(void) {
return;
/* avoid compiler warnings: */
hexdump(NULL, 100);
- remove_mapping(vvv, NULL);
+ remove_mapping(vvv, 0);
print_mapping(NULL);
print_direntry(NULL);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH] block: Fix compilation with DEBUG defined
2010-05-19 20:53 [Qemu-devel] [PATCH] block: Fix compilation with DEBUG defined Riccardo Magliocchetti
@ 2010-05-20 8:43 ` Kevin Wolf
2010-05-20 9:02 ` Riccardo Magliocchetti
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Wolf @ 2010-05-20 8:43 UTC (permalink / raw)
To: Riccardo Magliocchetti; +Cc: qemu-devel
Am 19.05.2010 22:53, schrieb Riccardo Magliocchetti:
> gcc does not like passing a NULL where an int value is expected:
>
> block/vvfat.c: In function ‘checkpoint’:
> block/vvfat.c:2868: error: passing argument 2 of ‘remove_mapping’ makes
> integer from pointer without a cast
>
> Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Thanks, applied to the block branch.
You're probably using a 32 bit platform? I needed another fix to get it
compiling on x86_64, which I just sent to the list.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH] block: Fix compilation with DEBUG defined
2010-05-20 8:43 ` [Qemu-devel] " Kevin Wolf
@ 2010-05-20 9:02 ` Riccardo Magliocchetti
0 siblings, 0 replies; 3+ messages in thread
From: Riccardo Magliocchetti @ 2010-05-20 9:02 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
Il 20/05/2010 10:43, Kevin Wolf ha scritto:
> Am 19.05.2010 22:53, schrieb Riccardo Magliocchetti:
>> gcc does not like passing a NULL where an int value is expected:
>>
>> block/vvfat.c: In function ‘checkpoint’:
>> block/vvfat.c:2868: error: passing argument 2 of ‘remove_mapping’ makes
>> integer from pointer without a cast
>>
>> Signed-off-by: Riccardo Magliocchetti<riccardo.magliocchetti@gmail.com>
>
> Thanks, applied to the block branch.
>
> You're probably using a 32 bit platform? I needed another fix to get it
> compiling on x86_64, which I just sent to the list.
Thanks, yes i'm on 32bit.
riccardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-20 9:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-19 20:53 [Qemu-devel] [PATCH] block: Fix compilation with DEBUG defined Riccardo Magliocchetti
2010-05-20 8:43 ` [Qemu-devel] " Kevin Wolf
2010-05-20 9:02 ` Riccardo Magliocchetti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).