From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57914 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OF5dk-0005im-68 for qemu-devel@nongnu.org; Thu, 20 May 2010 09:18:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OF5dS-0008Vu-Q5 for qemu-devel@nongnu.org; Thu, 20 May 2010 09:18:19 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:39582) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OF5dS-0008VU-Lp for qemu-devel@nongnu.org; Thu, 20 May 2010 09:18:02 -0400 Received: by gyd5 with SMTP id 5so3497049gyd.4 for ; Thu, 20 May 2010 06:18:01 -0700 (PDT) Message-ID: <4BF53682.7070402@codemonkey.ws> Date: Thu, 20 May 2010 08:17:54 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions. References: <1273063904-6028-1-git-send-email-kraxel@redhat.com> <1273063904-6028-2-git-send-email-kraxel@redhat.com> <4BE3BBA1.3010007@redhat.com> <4BF39E72.6070906@redhat.com> <4BF4372C.7060000@codemonkey.ws> <4BF52FE7.6000202@redhat.com> In-Reply-To: <4BF52FE7.6000202@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Blue Swirl , Paolo Bonzini , qemu-devel@nongnu.org On 05/20/2010 07:49 AM, Gerd Hoffmann wrote: > Hi, > >>>> Well. You can't have both. We can have a efficiently packed format >>>> (i.e. >>>> two bitmaps). Or we can do it in a way which doesn't need parsing, >>>> but that >>>> wouldn't be the most compact format ... >>> You're right, so packing or introducing a small conversion function is >>> not critical. I'd still prefer a standard format if possible. >> >> Personally, I'd rather see Gerd's original format but read from a file >> instead of hard coded in a .c file. IOW, a >> /usr/share/qemu/default-cursor.qpm that contained the appropriate >> strings. A couple extra lines that made it an xpm I think would be worth >> it too. > > xpms are designed to be easily #include-able, and parsing them that > way is easier than loading them at runtime. At least without adding a > dependency to libXpm. > > So how about the following incremental RfC patch? It adds the cursors > as separate files which are standard xpm format. Nevertheless they > are compiled in, i.e. they can't be changed at runtime. That works for me. Nice job. Regards, Anthony Liguori > cheers, > Gerd >