From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41448 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OF7lR-0007D7-Ui for qemu-devel@nongnu.org; Thu, 20 May 2010 11:34:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OF7lK-0006An-N8 for qemu-devel@nongnu.org; Thu, 20 May 2010 11:34:25 -0400 Received: from are.twiddle.net ([75.149.56.221]:43155) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OF7lK-0006AV-Fi for qemu-devel@nongnu.org; Thu, 20 May 2010 11:34:18 -0400 Message-ID: <4BF55678.7090208@twiddle.net> Date: Thu, 20 May 2010 08:34:16 -0700 From: Richard Henderson MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 04/10] target-mips: refactor {c, abs}.cond.fmt insns References: <1274367150-26576-1-git-send-email-froydnj@codesourcery.com> <1274367150-26576-5-git-send-email-froydnj@codesourcery.com> In-Reply-To: <1274367150-26576-5-git-send-email-froydnj@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nathan Froyd Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On 05/20/2010 07:52 AM, Nathan Froyd wrote: > +/* Tests */ > +#define OP_COND(name, cond) \ > +static inline void glue(gen_op_, name) (TCGv ret, TCGv t0, TCGv t1) \ > +{ \ > + int l1 = gen_new_label(); \ > + int l2 = gen_new_label(); \ > + \ > + tcg_gen_brcond_tl(cond, t0, t1, l1); \ > + tcg_gen_movi_tl(ret, 0); \ > + tcg_gen_br(l2); \ > + gen_set_label(l1); \ > + tcg_gen_movi_tl(ret, 1); \ > + gen_set_label(l2); \ > +} > +OP_COND(eq, TCG_COND_EQ); > +OP_COND(ne, TCG_COND_NE); > +OP_COND(ge, TCG_COND_GE); > +OP_COND(geu, TCG_COND_GEU); > +OP_COND(lt, TCG_COND_LT); > +OP_COND(ltu, TCG_COND_LTU); > +#undef OP_COND > + > +#define OP_CONDI(name, cond) \ ... > +#define OP_CONDZ(name, cond) \ What are these doing in this patch? r~