From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57162 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OFQbc-0001Oa-MX for qemu-devel@nongnu.org; Fri, 21 May 2010 07:41:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OFQba-0002Bd-8g for qemu-devel@nongnu.org; Fri, 21 May 2010 07:41:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60245) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OFQbZ-0002BT-Tu for qemu-devel@nongnu.org; Fri, 21 May 2010 07:41:30 -0400 Message-ID: <4BF6712F.5060300@redhat.com> Date: Fri, 21 May 2010 13:40:31 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1274333777-15415-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> In-Reply-To: <1274333777-15415-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] add support for protocol driver create_options List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: MORITA Kazutaka Cc: sheepdog@lists.wpkg.org, hch@lst.de, kvm@vger.kernel.org, qemu-devel@nongnu.org Am 20.05.2010 07:36, schrieb MORITA Kazutaka: > This patch enables protocol drivers to use their create options which > are not supported by the format. For example, protcol drivers can use > a backing_file option with raw format. > > Signed-off-by: MORITA Kazutaka Hm, this is not stackable, right? Though I do see that making it stackable would require some bigger changes, so maybe we can get away with claiming that this approach covers everything that happens in practice. If we accept that this is the desired behaviour, the code looks good to me. Kevin