From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38854 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OFVa0-0005I4-Gr
	for qemu-devel@nongnu.org; Fri, 21 May 2010 13:00:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1OFVZs-0001UH-PO
	for qemu-devel@nongnu.org; Fri, 21 May 2010 13:00:11 -0400
Received: from are.twiddle.net ([75.149.56.221]:59055)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1OFVZs-0001UA-Ge
	for qemu-devel@nongnu.org; Fri, 21 May 2010 13:00:04 -0400
Received: from anchor.twiddle.home (anchor.twiddle.home [172.31.0.4])
	by are.twiddle.net (Postfix) with ESMTPSA id EA40E47
	for <qemu-devel@nongnu.org>; Fri, 21 May 2010 10:00:03 -0700 (PDT)
Message-ID: <4BF6BC13.6040706@twiddle.net>
Date: Fri, 21 May 2010 10:00:03 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg
	stub	(tcg_out_reloc)
References: <1273595012-19587-1-git-send-email-agraf@suse.de>
	<20100521164641.GA4989@volta.aurel32.net>
In-Reply-To: <20100521164641.GA4989@volta.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 05/21/2010 09:46 AM, Aurelien Jarno wrote:
>> +    tcg_out_reloc(NULL, NULL, 0, 0, 0);
>>  }
>>  
> 
> What about declaring tcg_out_reloc static inline?

I think we're not far away from a mergable s390 port.
I think the smallest local change is best in the interim.


r~