From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45185 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OG8dE-0005g6-0C for qemu-devel@nongnu.org; Sun, 23 May 2010 06:42:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OG8dC-0002aa-Nm for qemu-devel@nongnu.org; Sun, 23 May 2010 06:42:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12192) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OG8dC-0002aR-CW for qemu-devel@nongnu.org; Sun, 23 May 2010 06:42:06 -0400 Message-ID: <4BF9067B.3050200@redhat.com> Date: Sun, 23 May 2010 13:42:03 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1f557b9feb1965a61e64f7166bcf4918bed8d0ec.1274516288.git.jan.kiszka@web.de> <4BF82895.6000706@redhat.com> <4BF8DFF7.5070302@web.de> <4BF8EAFB.2080807@redhat.com> <4BF8FD83.60600@web.de> In-Reply-To: <4BF8FD83.60600@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state visualization List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , Juan Quintela , Jan Kiszka , Markus Armbruster , qemu-devel@nongnu.org, Luiz Capitulino On 05/23/2010 01:03 PM, Jan Kiszka wrote: >>> >>> Can your elaborate what precisely is ambiguous? >>> >>> >> Can't the user choose the unique ID so that it aliases an unrelated >> qtree path? >> > True. I'll swap the search order and document this. Qtree paths should > always rule. > Well, I guess the user could avoid ambiguity by avoiding /es. > >> I prefer having mutually exclusive 'path' and 'ref' arguments. >> > That would be unhandy. > Don't really see why. >> I agree. This feature is very useful as a debugging aid, and as I don't >> think we'll have debugging GUIs any time soon, it's better to defer the >> problem until we really need to solve it. >> > I introduced .user_only as a monitor command tag and applied it on > device_show. But I also added the vmstate version to the device output, > maybe already helpful for users. All this will come with v3. > Thanks. -- error compiling committee.c: too many arguments to function