From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46672 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OGTY9-0004Wu-2g
	for qemu-devel@nongnu.org; Mon, 24 May 2010 05:02:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OGTY6-0002Di-OI
	for qemu-devel@nongnu.org; Mon, 24 May 2010 05:02:16 -0400
Received: from mail-ww0-f45.google.com ([74.125.82.45]:64013)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OGTY6-0002DG-0z
	for qemu-devel@nongnu.org; Mon, 24 May 2010 05:02:14 -0400
Received: by wwg30 with SMTP id 30so373374wwg.4
	for <qemu-devel@nongnu.org>; Mon, 24 May 2010 02:02:12 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4BFA408E.8060807@redhat.com>
Date: Mon, 24 May 2010 11:02:06 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1274688090.git.quintela@redhat.com>
	<9fed8fc8d5a596bd8fdf125ffadc8f55dc39eb2b.1274688090.git.quintela@redhat.com>
In-Reply-To: <9fed8fc8d5a596bd8fdf125ffadc8f55dc39eb2b.1274688090.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/5] Exit if incoming migration fails
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org


> -void qemu_start_incoming_migration(const char *uri)
> +int qemu_start_incoming_migration(const char *uri)
>   {
>       const char *p;
> +    int ret = -1;

Maybe -ENOSYS or -EPROTONOSUPPORT, since the *_start_incoming_migration 
functions return a negative errno value?

>       if (incoming) {
> -        qemu_start_incoming_migration(incoming);
> +        if (qemu_start_incoming_migration(incoming)<  0) {
> +            fprintf(stderr, "unknown migration protocol: %s\n", incoming);
> +            exit(1);
> +        }

Dually, if you have a failure from *_start_incoming_migration, this 
fprintf is spurious.

Paolo