From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36432 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGc7R-0004ID-Gz for qemu-devel@nongnu.org; Mon, 24 May 2010 14:12:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGc6N-0005Ac-B3 for qemu-devel@nongnu.org; Mon, 24 May 2010 14:11:02 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:58190) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGc6M-00059z-VX for qemu-devel@nongnu.org; Mon, 24 May 2010 14:10:11 -0400 Message-ID: <4BFAC0FD.5050505@web.de> Date: Mon, 24 May 2010 20:10:05 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <201005241732.46988.paul@codesourcery.com> <4BFAAE22.5040900@codemonkey.ws> <201005241811.10219.paul@codesourcery.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig03EAB4D0EA7E6561811648A3" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Blue Swirl , Paul Brook , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig03EAB4D0EA7E6561811648A3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Juan Quintela wrote: > Paul Brook wrote: >>> On 05/24/2010 11:32 AM, Paul Brook wrote: >>>>> Notice that this patch was sent against hpet as one example, if we = agree >>>>> that this "way" of disabling devices is ok, we could disable more >>>>> devices/have more flexibility. Notice that in general, we (RHEL/KV= M) >>>>> are interested in a small subset of qemu devices. >>>> IMO this patch is a backwards step. The device models should be cle= aned >>>> up so that you don't need to make a compile time decision. >>> I disagree. I think the device model should be cleaned up so that no= >>> CONFIG_HPET is required in code but I think it's still useful to be a= ble >>> to exclude device models from the build. That should just be a matte= r >>> of not building the object though (that's the point of device_init())= =2E >> I think we're saying the same thing. >> >> We already have a mechanism for avoiding things at build time - specif= ically=20 >> config-devices.mak. We don't have a nice UI for it, but it's there. >> At worst your distro specific patch is a 1-line change to default- >> configs/i386-softmmu.mak. >> >> I have no objection to moving hpet.c into Makefile.objs, conditional o= n=20 >> CONFIG_HPET (like e.g. CONFIG_SERIAL/serial.o). However a necessary=20 >> prerequisite is that you fix the device model and machine initialisati= on so=20 >> that it's possible to omit hpet.o without rebuilding anything else. >=20 > We have two exported functions: >=20 > void hpet_init(qemu_irq *irq); > uint32_t hpet_in_legacy_mode(void); One, hpet_in_legacy_mode will become hpet-private. Once done, I will have a look if we can cleanly push more x86 platform logic related to the HPET IRQ routing into hpet_init. Jan --------------enig03EAB4D0EA7E6561811648A3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkv6wQAACgkQitSsb3rl5xQAUACbBjB8a0UBM7pONM9gsOnS75di m24An1/QqPHmA/Hj89bwaqngY7dzXfKQ =4pXB -----END PGP SIGNATURE----- --------------enig03EAB4D0EA7E6561811648A3--