From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41514 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OGeAS-0006m5-Sg
	for qemu-devel@nongnu.org; Mon, 24 May 2010 16:22:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OGeAN-0001UL-2G
	for qemu-devel@nongnu.org; Mon, 24 May 2010 16:22:32 -0400
Received: from mail-pv0-f173.google.com ([74.125.83.173]:38509)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OGeAK-0001U4-FC
	for qemu-devel@nongnu.org; Mon, 24 May 2010 16:22:26 -0400
Received: by pvg16 with SMTP id 16so147701pvg.4
	for <qemu-devel@nongnu.org>; Mon, 24 May 2010 13:22:23 -0700 (PDT)
Message-ID: <4BFADFFA.3040905@codemonkey.ws>
Date: Mon, 24 May 2010 15:22:18 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state
	visualization
References: <cover.1274516288.git.jan.kiszka@web.de>	<1f557b9feb1965a61e64f7166bcf4918bed8d0ec.1274516288.git.jan.kiszka@web.de>	<4BF82895.6000706@redhat.com>
	<4BF8DFF7.5070302@web.de> <20100524095118.539f2b9e@redhat.com>
In-Reply-To: <20100524095118.539f2b9e@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Juan Quintela <quintela@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Jan Kiszka <jan.kiszka@web.de>, Avi Kivity <avi@redhat.com>

On 05/24/2010 07:51 AM, Luiz Capitulino wrote:
> On Sun, 23 May 2010 09:57:43 +0200
> Jan Kiszka<jan.kiszka@web.de>  wrote:
>
>    
>> Avi Kivity wrote:
>>      
> [...]
>
>    
>>>        
>>>> +- "full": report full state (json-bool, optional)
>>>>
>>>>          
>>> Is this needed for QMP?  The client can always truncate it to any length.
>>>        
>> The effect may not be needed for QMP, but I do need this channel from
>> the command line to the monitor pretty-printer. I could just stick
>> "full": json-bool back into the return dict, but that would look somehow
>> strange IMO.
>>      
>   We could have a form of optional key which is only present internally,
> we have that async commands.
>    

I'd rather see two separate commands with an internal mechanism to make 
direct QMP calls.  The human monitor can be implemented in terms of the 
QMP call but it should be in terms of the human monitor invoking the QMP 
command such that it can munge the output as it sees appropriate.

Regards,

Anthony Liguori