From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50813 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OGeGT-0002HE-NB
	for qemu-devel@nongnu.org; Mon, 24 May 2010 16:28:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OGeGM-0002E1-JK
	for qemu-devel@nongnu.org; Mon, 24 May 2010 16:28:44 -0400
Received: from mail-pv0-f173.google.com ([74.125.83.173]:42242)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OGeGM-0002Dm-AW
	for qemu-devel@nongnu.org; Mon, 24 May 2010 16:28:38 -0400
Received: by pvg16 with SMTP id 16so150185pvg.4
	for <qemu-devel@nongnu.org>; Mon, 24 May 2010 13:28:37 -0700 (PDT)
Message-ID: <4BFAE170.2000707@codemonkey.ws>
Date: Mon, 24 May 2010 15:28:32 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] sdl: Do not disable screensaver by default
References: <20100520181304.10437.90521.malonedeb@potassium.ubuntu.com>	<20100522234727.1683.30745.malone@palladium.canonical.com>
	<4BF8E76E.7040601@web.de>
In-Reply-To: <4BF8E76E.7040601@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: j.r.versteegh@gmail.com, Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org

On 05/23/2010 03:29 AM, Jan Kiszka wrote:
> From: Jan Kiszka<jan.kiszka@siemens.com>
>
> Unless we are running in full-screen mode, QEMU's SDL window should not
> disable the host's screensaver. The user can still change this behaviour
> by setting the environment variable SDL_VIDEO_ALLOW_SCREENSAVER as
> desired.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>    

Applied.  Thanks.

This also fixes https://bugs.launchpad.net/qemu/+bug/583462.

Regards,

Anthony Liguori

> ---
>
> Cool, thanks for digging out SDL_VIDEO_ALLOW_SCREENSAVER. I came across
> by this issue as well but I was too lazy to analyze to reason. This
> patch solves it for me.
>
>   sdl.c |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/sdl.c b/sdl.c
> index 16a48e9..3bdd518 100644
> --- a/sdl.c
> +++ b/sdl.c
> @@ -855,6 +855,10 @@ void sdl_display_init(DisplayState *ds, int full_screen, int no_frame)
>       if (no_frame)
>           gui_noframe = 1;
>
> +    if (!full_screen) {
> +        setenv("SDL_VIDEO_ALLOW_SCREENSAVER", "1", 0);
> +    }
> +
>       flags = SDL_INIT_VIDEO | SDL_INIT_NOPARACHUTE;
>       if (SDL_Init (flags)) {
>           fprintf(stderr, "Could not initialize SDL(%s) - exiting\n",
>