From: Anthony Liguori <anthony@codemonkey.ws>
To: akong@redhat.com
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, alex.williamson@hp.com
Subject: Re: [Qemu-devel] [PATCH] Virtio-net: Replace the hardcode 6 with defined ETN_ALEN
Date: Mon, 24 May 2010 15:29:50 -0500 [thread overview]
Message-ID: <4BFAE1BE.5030800@codemonkey.ws> (raw)
In-Reply-To: <1274582950-4418-1-git-send-email-akong@redhat.com>
On 05/22/2010 09:49 PM, akong@redhat.com wrote:
> From: Amos Kong<akong@redhat.com>
>
> hw/virtio-net.h:
> #define ETH_ALEN 6
> ETH_ALEN was defined by commit 7967406801aa897fae83caad3278ac85a342adaa
>
> Signed-off-by: Amos Kong<akong@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> hw/virtio-net.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/virtio-net.h b/hw/virtio-net.h
> index e55119b..235f1a9 100644
> --- a/hw/virtio-net.h
> +++ b/hw/virtio-net.h
> @@ -54,8 +54,8 @@
>
> struct virtio_net_config
> {
> - /* The config defining mac address (6 bytes) */
> - uint8_t mac[6];
> + /* The config defining mac address ($ETH_ALEN bytes) */
> + uint8_t mac[ETH_ALEN];
> /* See VIRTIO_NET_F_STATUS and VIRTIO_NET_S_* above */
> uint16_t status;
> } __attribute__((packed));
>
prev parent reply other threads:[~2010-05-24 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 2:49 [Qemu-devel] [PATCH] Virtio-net: Replace the hardcode 6 with defined ETN_ALEN akong
2010-05-24 20:29 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFAE1BE.5030800@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=akong@redhat.com \
--cc=alex.williamson@hp.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).