From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56937 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OGftQ-000819-Hi
	for qemu-devel@nongnu.org; Mon, 24 May 2010 18:13:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OGfsm-0007Yi-OK
	for qemu-devel@nongnu.org; Mon, 24 May 2010 18:13:04 -0400
Received: from mail-gx0-f218.google.com ([209.85.217.218]:57670)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OGfsm-0007YT-M8
	for qemu-devel@nongnu.org; Mon, 24 May 2010 18:12:24 -0400
Received: by gxk10 with SMTP id 10so1212610gxk.10
	for <qemu-devel@nongnu.org>; Mon, 24 May 2010 15:12:24 -0700 (PDT)
Message-ID: <4BFAF9C5.403@codemonkey.ws>
Date: Mon, 24 May 2010 17:12:21 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] resent: fix CPUID vendor override
References: <1274421493-9036-1-git-send-email-andre.przywara@amd.com>
In-Reply-To: <1274421493-9036-1-git-send-email-andre.przywara@amd.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andre Przywara <andre.przywara@amd.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net, kvm-devel <kvm@vger.kernel.org>

On 05/21/2010 12:58 AM, Andre Przywara wrote:
> the meaning of vendor_override is actually the opposite of how it
> is currently used :-(
> Fix it to allow KVM to export the non-native CPUID vendor if
> explicitly requested by the user.
> The semantic is now as intended:
> - With TCG, the guest always sees the configured vendor.
> - With KVM, the default is to propagate the host's vendor
>    - when explicitly requested via -cpu<base>,vendor=xxx obey this
>      and use the specified vendor
>
> Signed-off-by: Andre Przywara<andre.przywara@amd.com>
>    

This should go through uq/master.  But I'm not sure that the new 
behavior is really what's desired.  It's certainly going to break 
compatibility since -M pc-0.12 is going to show a different vendor_id by 
default.

Regards,

Anthony Liguori

> ---
>   target-i386/cpuid.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> Hi,
>
> this hasn't been picked up the last time I sent it out, are there any
> objections?
>
> Regards,
> Andre.
>
> diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
> index 56938e2..99d1f44 100644
> --- a/target-i386/cpuid.c
> +++ b/target-i386/cpuid.c
> @@ -962,7 +962,7 @@ static void get_cpuid_vendor(CPUX86State *env, uint32_t *ebx,
>        * this if you want to use KVM's sysenter/syscall emulation
>        * in compatibility mode and when doing cross vendor migration
>        */
> -    if (kvm_enabled()&&  env->cpuid_vendor_override) {
> +    if (kvm_enabled()&&  ! env->cpuid_vendor_override) {
>           host_cpuid(0, 0, NULL, ebx, ecx, edx);
>       }
>   }
>