From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49058 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGg8b-0000p9-14 for qemu-devel@nongnu.org; Mon, 24 May 2010 18:28:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGg8W-0000oI-3d for qemu-devel@nongnu.org; Mon, 24 May 2010 18:28:44 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:48048) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGg8V-0000o8-TZ for qemu-devel@nongnu.org; Mon, 24 May 2010 18:28:40 -0400 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by e39.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o4OMJmVo003264 for ; Mon, 24 May 2010 16:19:48 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o4OMRtcb142146 for ; Mon, 24 May 2010 16:27:55 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o4OMRtic024941 for ; Mon, 24 May 2010 16:27:55 -0600 Message-ID: <4BFAFD69.9040201@linux.vnet.ibm.com> Date: Mon, 24 May 2010 17:27:53 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state visualization References: <1f557b9feb1965a61e64f7166bcf4918bed8d0ec.1274516288.git.jan.kiszka@web.de> <4BF82895.6000706@redhat.com> <4BFAE004.6090501@codemonkey.ws> <4BFAE302.40806@web.de> <4BFAF477.4030303@linux.vnet.ibm.com> <4BFAF9CE.8010706@web.de> In-Reply-To: <4BFAF9CE.8010706@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Juan Quintela , Jan Kiszka , qemu-devel@nongnu.org, Luiz Capitulino , Avi Kivity , Markus Armbruster On 05/24/2010 05:12 PM, Jan Kiszka wrote: > Anthony Liguori wrote: > >> On 05/24/2010 03:35 PM, Jan Kiszka wrote: >> >>> In contrast to save/loadvm, device_show does not provide a >>> backward-compatible output. Not only field names can change (as a result >>> of internal refactoring), >>> >> Field names could change, but that seems unlikely and unnecessary. >> > Actually, this may happen to improve the output format for device_show, > either via renaming the fields or annotating it (once we have the latter > mechanism). I don't think it's a huge win vs. stability. >> The output of device_show when >> specifying -M pc-0.13 should always be the same. If it's not, I believe >> that's a bug. >> >> The output of device_show across multiple qemu versions without >> specifying a -M could certainly be different but that's to be expected >> since you have a different hardware model. >> > It will be different as soon as the version_id of a dumped vmstate > changes, even independent of -M. > But QMP stability is only guaranteed for releases and -M pc-0.12 should (in a perfect world) always dump out the same versions regardless of whether it's qemu-0.12, qemu-0.13, etc. Regards, Anthony Liguori > Jan > >