From: Gerd Hoffmann <kraxel@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] ioport: add function to check whenever a port is assigned or not
Date: Tue, 25 May 2010 11:41:29 +0200 [thread overview]
Message-ID: <4BFB9B49.9080503@redhat.com> (raw)
In-Reply-To: <201005241332.51768.paul@codesourcery.com>
On 05/24/10 14:32, Paul Brook wrote:
>> +int is_ioport_assigned(pio_addr_t addr)
>
> Shouldn't we move this into register_ioport_{read,write}, and have that fail
> if the port has already been assigned?
It already checks and fails with hw_error(). Problem with that is that
this kills qemu in case you try to pci hot-plug a vga card. So I've
added a way to check before-hand, so we can fail gracefully in the few
places where we need it (see second patch of the series).
cheers,
Gerd
next prev parent reply other threads:[~2010-05-25 9:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 9:54 [Qemu-devel] [PATCH 1/2] ioport: add function to check whenever a port is assigned or not Gerd Hoffmann
2010-05-19 9:54 ` [Qemu-devel] [PATCH 2/2] all vga: fail graicefully when vga ports are taken Gerd Hoffmann
2010-05-24 12:32 ` [Qemu-devel] [PATCH 1/2] ioport: add function to check whenever a port is assigned or not Paul Brook
2010-05-25 9:41 ` Gerd Hoffmann [this message]
2010-05-26 7:05 ` Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2010-05-11 20:43 Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFB9B49.9080503@redhat.com \
--to=kraxel@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).