From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40664 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGr9T-0007rC-8F for qemu-devel@nongnu.org; Tue, 25 May 2010 06:14:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGr9P-0007ru-6s for qemu-devel@nongnu.org; Tue, 25 May 2010 06:14:23 -0400 Received: from thoth.sbs.de ([192.35.17.2]:18347) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGr9O-0007rT-Pk for qemu-devel@nongnu.org; Tue, 25 May 2010 06:14:19 -0400 Message-ID: <4BFBA2F2.2010307@siemens.com> Date: Tue, 25 May 2010 12:14:10 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFT][PATCH 05/15] hpet: Convert to qdev References: <3d07ca44a4c2332d3f6247033031e891d3678804.1274732025.git.jan.kiszka@web.de> <201005251037.41646.paul@codesourcery.com> In-Reply-To: <201005251037.41646.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: blue Swirl , Jan Kiszka , "qemu-devel@nongnu.org" , Juan Quintela Paul Brook wrote: >> +static SysBusDeviceInfo hpet_device_info = { >> + .qdev.name = "hpet", >> + .qdev.size = sizeof(HPETState), >> + .qdev.no_user = 1, > > Why shouldn't the user create HPET devices? I thought you'd removed all the > global state. Long-term, there is no reason to deny this. But the code is not yet ready for this: we statically instantiate it during PC setup to establish the routings and respect -no-hpat. Also, the BIOS isn't prepared for > 1 HPET. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux