From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47711 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OGrIo-00062B-I2
	for qemu-devel@nongnu.org; Tue, 25 May 2010 06:24:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OGrIn-0001KQ-84
	for qemu-devel@nongnu.org; Tue, 25 May 2010 06:24:02 -0400
Received: from thoth.sbs.de ([192.35.17.2]:20672)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OGrIm-0001Jg-Ul
	for qemu-devel@nongnu.org; Tue, 25 May 2010 06:24:01 -0400
Message-ID: <4BFBA539.6010305@siemens.com>
Date: Tue, 25 May 2010 12:23:53 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFT][PATCH 09/15] hpet/rtc: Rework RTC IRQ
	replacement by HPET
References: <cover.1274732025.git.jan.kiszka@web.de>
	<b46a7c542c3b0b5e6f800d966b31f21672c6cae9.1274732025.git.jan.kiszka@web.de>
	<201005251029.49089.paul@codesourcery.com>
In-Reply-To: <201005251029.49089.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: blue Swirl <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@web.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>

Paul Brook wrote:
>>          for (i = 0; i < 24; i++) {
>>              sysbus_connect_irq(sysbus_from_qdev(hpet), i, isa_irq[i]);
>>          }
>> +        rtc_irq = qemu_allocate_feedback_irqs(hpet_handle_rtc_irq,
>> +                                              sysbus_from_qdev(hpet), 1);
>>      }
> 
> This is wrong. The hpet device should expose this as an IO pin.

Will look into this.

BTW, I just realized that the GPIO handling is apparently lacking
support for attaching an output to multiple inputs. Or am I missing
something?

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux