From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41231 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGuUG-0006NZ-0V for qemu-devel@nongnu.org; Tue, 25 May 2010 09:48:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGuUA-00036C-1a for qemu-devel@nongnu.org; Tue, 25 May 2010 09:47:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28401) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGuU9-000360-R3 for qemu-devel@nongnu.org; Tue, 25 May 2010 09:47:58 -0400 Message-ID: <4BFBD500.60300@redhat.com> Date: Tue, 25 May 2010 16:47:44 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] resent: x86/cpuid: propagate further CPUID leafs when -cpu host References: <1274428240-10801-1-git-send-email-andre.przywara@amd.com> <4BFAF941.1010604@codemonkey.ws> <4BFBCEEA.4030101@amd.com> <4BFBCFF0.70506@codemonkey.ws> In-Reply-To: <4BFBCFF0.70506@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Andre Przywara , "qemu-devel@nongnu.org" , "aurelien@aurel32.net" On 05/25/2010 04:26 PM, Anthony Liguori wrote: > On 05/25/2010 08:21 AM, Andre Przywara wrote: >>> What's the benefit of exposing this information to the guest? >> >> That is mostly to propagate the cache size and organization >> parameters to the guest: >> >> +/* safe CPUID leafs to propagate to guest if -cpu host is specified >> >> + * Intel defined leafs: >> >> + * Cache descriptors (0x02) >> >> + * Deterministic cache parameters (0x04) >> >> + * Monitor/MWAIT parameters (0x05) >> >> + * >> >> + * AMD defined leafs: >> >> + * L1 Cache and TLB (0x05) >> >> + * L2+L3 TLB (0x06) >> >> + * LongMode address size (0x08) >> >> + * 1GB page TLB (0x19) >> >> + * Performance optimization (0x1A) >> >> + */ >> Since at least L1 and L2 caches are mostly private to vCPUs, I see no >> reason to disguise them. > > But in practice, what is it useful for? See my other mail. > Just because we can expose it doesn't mean we should. What's the point of -cpu host then? -- error compiling committee.c: too many arguments to function