From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45757 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OGuYj-0006hK-W9
	for qemu-devel@nongnu.org; Tue, 25 May 2010 09:52:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OGuYh-00044S-UJ
	for qemu-devel@nongnu.org; Tue, 25 May 2010 09:52:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37228)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OGuYh-00044D-M2
	for qemu-devel@nongnu.org; Tue, 25 May 2010 09:52:39 -0400
Message-ID: <4BFBD622.20100@redhat.com>
Date: Tue, 25 May 2010 16:52:34 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1274783056-14759-1-git-send-email-stefanha@linux.vnet.ibm.com>	
	<1274783056-14759-8-git-send-email-stefanha@linux.vnet.ibm.com>	
	<4BFBBCC3.2080905@redhat.com>
	<AANLkTim98TWkzQoK_5y0zfDJTnsK-L6w9evP2niUp2DD@mail.gmail.com>
In-Reply-To: <AANLkTim98TWkzQoK_5y0zfDJTnsK-L6w9evP2niUp2DD@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 7/7] trace: Trace virtqueue operations
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Prerna Saxena <prerna@linux.vnet.ibm.com>

On 05/25/2010 04:27 PM, Stefan Hajnoczi wrote:
> On Tue, May 25, 2010 at 1:04 PM, Avi Kivity<avi@redhat.com>  wrote:
>    
>> Those %ps are more or less useless.  We need better ways of identifying
>> them.
>>      
> You're right, the vq pointer is useless in isolation.  We don't know
> which virtio device or which virtqueue number.
>
> With the full context of a trace it would be possible to correlate the
> vq pointer if we had trace events for vdev and vq setup.
>
> Adding custom formatters is could be tricky since the format string is
> passed only to tracing backends that use it, like UST.  And UST uses
> its own sprintf implementation which we don't have direct control
> over.
>    

Hm.  Perhaps we can convert %{type} to %p for backends which don't 
support it, and to whatever format they do support for those that do.

-- 
error compiling committee.c: too many arguments to function