From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36416 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OHEau-0003HB-No
	for qemu-devel@nongnu.org; Wed, 26 May 2010 07:16:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OHEat-00018M-Le
	for qemu-devel@nongnu.org; Wed, 26 May 2010 07:16:16 -0400
Received: from goliath.siemens.de ([192.35.17.28]:18222)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OHEat-000187-Br
	for qemu-devel@nongnu.org; Wed, 26 May 2010 07:16:15 -0400
Message-ID: <4BFD02FC.6020401@siemens.com>
Date: Wed, 26 May 2010 13:16:12 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <201005261207.31310.frank.mehnert@sun.com>	<4BFCF8AF.8030300@siemens.com>
	<201005261306.07673.frank.mehnert@sun.com>
In-Reply-To: <201005261306.07673.frank.mehnert@sun.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: hw/serial.c: Xmit fifo never used
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Frank Mehnert <Frank.Mehnert@Sun.COM>
Cc: qemu-devel@nongnu.org

Frank Mehnert wrote:
> On Wednesday 26 May 2010, Jan Kiszka wrote:
>> Frank Mehnert wrote:
>>> I assume the correct condition would be '>= 0', that is
>>>
>>>         ...
>>>         if ((s->tsr_retry >= 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) {
>>>             s->tsr_retry++;
>>>         ...
>> Makes sense, patch welcome.
> 
> Attached.

Signed-off, subject, and description please. And I would keep Stefano as
the original author of this feature in CC. A cross-check by him might be
good as we enable a code path that was apparently dead so far.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux