From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40277 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHFsE-00071L-13 for qemu-devel@nongnu.org; Wed, 26 May 2010 08:38:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OHFsC-0003Gm-36 for qemu-devel@nongnu.org; Wed, 26 May 2010 08:38:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23318) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHFsB-0003Gd-Pj for qemu-devel@nongnu.org; Wed, 26 May 2010 08:38:12 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4QCcAEJ013250 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 26 May 2010 08:38:10 -0400 Message-ID: <4BFD162D.4000907@redhat.com> Date: Wed, 26 May 2010 14:38:05 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1274873265-24393-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1274873265-24393-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2] qdev-properties: Fix (u)intXX parsers List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, armbru@redhat.com On 05/26/10 13:27, Kevin Wolf wrote: > scanf calls must not use PRI constants, they have probably the wrong size and > corrupt memory. We could replace them by SCN ones, but strtol is simpler than > scanf here anyway. While at it, also fix the parsers to reject garbage after > the number ("4096xyz" was accepted before). > Looks good to me. Acked-by: Gerd Hoffmann cheers, Gerd