From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44779 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OHYLP-0004h1-Sd
	for qemu-devel@nongnu.org; Thu, 27 May 2010 04:21:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OHYLC-0000qM-2u
	for qemu-devel@nongnu.org; Thu, 27 May 2010 04:21:34 -0400
Received: from goliath.siemens.de ([192.35.17.28]:23960)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OHYLB-0000q5-Qo
	for qemu-devel@nongnu.org; Thu, 27 May 2010 04:21:22 -0400
Message-ID: <4BFE2B7C.2070102@siemens.com>
Date: Thu, 27 May 2010 10:21:16 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: hw/serial.c: Xmit fifo never used
References: <201005261207.31310.frank.mehnert@sun.com>
	<4BFD02FC.6020401@siemens.com>
	<alpine.DEB.2.00.1005261241030.25605@kaball-desktop>
	<201005262206.11919.frank.mehnert@sun.com>
In-Reply-To: <201005262206.11919.frank.mehnert@sun.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Frank Mehnert <Frank.Mehnert@sun.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Frank Mehnert wrote:
> On Wednesday 26 May 2010, Stefano Stabellini wrote:
>> I think the patch is correct.
> 
> serial: fixed bug which prevented the use of the xmit fifo
> 
> Signed-off-by: Frank Mehnert <frank.mehnert@sun.com>
> ---
>  hw/serial.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/serial.c b/hw/serial.c
> index 9102edb..0b1550b 100644
> --- a/hw/serial.c
> +++ b/hw/serial.c
> @@ -327,7 +327,7 @@ static void serial_xmit(void *opaque)
>          /* in loopback mode, say that we just received a char */
>          serial_receive1(s, &s->tsr, 1);
>      } else if (qemu_chr_write(s->chr, &s->tsr, 1) != 1) {
> -        if ((s->tsr_retry > 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) {
> +        if ((s->tsr_retry >= 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) {
>              s->tsr_retry++;
>              qemu_mod_timer(s->transmit_timer,  new_xmit_ts + 
> s->char_transmit_time);
>              return;
> --
> 1.5.6.5
> 
> 
> 
> Hope this is now the correct format.

Really close: Without "[PATCH]" prefix in the subject line there is the
risk that no maintainer will find your patch. Moreover, your mail client
wrapped long lines.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux