From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48216 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHlRY-00035e-5F for qemu-devel@nongnu.org; Thu, 27 May 2010 18:20:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OHlQw-0001kq-UN for qemu-devel@nongnu.org; Thu, 27 May 2010 18:20:15 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:44106) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHlQw-0001km-IU for qemu-devel@nongnu.org; Thu, 27 May 2010 18:20:10 -0400 Message-ID: <4BFEF018.9000705@web.de> Date: Fri, 28 May 2010 00:20:08 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <5d0139dc62706a1efcbb6a63d5936484ad279916.1274612367.git.jan.kiszka@web.de> <20100527173147.304ee68b@redhat.com> In-Reply-To: <20100527173147.304ee68b@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigD7B58CD58E2D414439C2ED29" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH v3 13/17] monitor: Allow to exclude commands from QMP List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Anthony Liguori , Juan Quintela , Jan Kiszka , qemu-devel@nongnu.org, Markus Armbruster , Blue Swirl , Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD7B58CD58E2D414439C2ED29 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Luiz Capitulino wrote: > On Sun, 23 May 2010 12:59:26 +0200 > Jan Kiszka wrote: >=20 >> From: Jan Kiszka >> >> Ported commands that are marked 'user_only' will not be considered for= >> QMP monitor sessions. This allows to implement new commands that do no= t >> (yet) provide a sufficiently stable interface for QMP use (e.g. >> device_show). >=20 > This is fine for me, but two things I've been wondering: >=20 > 1. Isn't a 'flags' struct member better? So that we can do (in the > qemu-monitor.hx entry): >=20 > .flags =3D MONITOR_USER_ONLY | MONITOR_HANDLER_ASYNC, >=20 > I'm not suggesting this is an async handler, just exemplifying mult= iple > flags. Yes, can refactor this. >=20 > 2. Getting QMP handlers right in the first time might be difficult, s= o > we could have a way to mark them unstable. Maybe a different names= pace > which is only enabled at configure time with: >=20 > --enable-qmp-unstable-commands >=20 > If this were possible, we could have device_show and any command w= e > aren't sure is QMP-ready working in QMP this way. Do you suggest this as an alternative to this patch? Or an extension later on? I have no opinion on this yet, I would just like to know how to proceed for this series. Jan --------------enigD7B58CD58E2D414439C2ED29 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEUEARECAAYFAkv+8BgACgkQitSsb3rl5xS0WACeNr+kwQrGhoFuc8fN8O35SveO fF0Al1Gxv0SfFwp1e2+s+IhLBKOg9zU= =q7qu -----END PGP SIGNATURE----- --------------enigD7B58CD58E2D414439C2ED29--