From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58105 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHlUS-0003iE-U4 for qemu-devel@nongnu.org; Thu, 27 May 2010 18:26:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OHlRM-0001na-Cx for qemu-devel@nongnu.org; Thu, 27 May 2010 18:20:37 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:36675) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHlRL-0001nR-VV for qemu-devel@nongnu.org; Thu, 27 May 2010 18:20:36 -0400 Message-ID: <4BFEF032.4080203@web.de> Date: Fri, 28 May 2010 00:20:34 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20100527170803.6477625d@redhat.com> In-Reply-To: <20100527170803.6477625d@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigA18AC760BF90F9722B5B3246" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH v3 10/17] QMP: Reserve namespace for complex object classes List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Anthony Liguori , Juan Quintela , Jan Kiszka , qemu-devel@nongnu.org, Markus Armbruster , Blue Swirl , Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA18AC760BF90F9722B5B3246 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Luiz Capitulino wrote: > On Sun, 23 May 2010 12:59:23 +0200 > Jan Kiszka wrote: >=20 >> From: Jan Kiszka >> >> This reserves JSON objects that contain the key '__class__' for QMP-sp= ecific >> complex objects. First user will be the buffer class. >> >> Signed-off-by: Jan Kiszka >> --- >> QMP/qmp-spec.txt | 16 +++++++++++++--- >> 1 files changed, 13 insertions(+), 3 deletions(-) >> >> diff --git a/QMP/qmp-spec.txt b/QMP/qmp-spec.txt >> index 9d30a8c..fa1dd62 100644 >> --- a/QMP/qmp-spec.txt >> +++ b/QMP/qmp-spec.txt >> @@ -146,6 +146,15 @@ The format is: >> For a listing of supported asynchronous events, please, refer to the >> qmp-events.txt file. >> =20 >> +2.6 Complex object classes >> +-------------------------- >> + >> +JSON objects that contain the key-value pair '"__class__": json-strin= g' are >=20 > I'm not strong about this, but it's better to call it just a 'pair', a= s 'value' > is a bit problematic because of json-value. Hmm, the official term is "name/value pairs". Will use that instead. >=20 >> +reserved for QMP-specific complex object classes that. QMP specifies = which >=20 > Early full stop? Obviously. I just don't remember what I wanted to add. >=20 >> +further keys each of these objects include and how they are encoded. >> + >> +So far, no complex object class is specified. >> + >> 3. QMP Examples >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> =20 >> @@ -229,9 +238,10 @@ avoid modifying QMP. Both upstream and downstrea= m need to take care to >> preserve long-term compatibility and interoperability. >> =20 >> To help with that, QMP reserves JSON object member names beginning wi= th >> -'__' (double underscore) for downstream use ("downstream names"). Th= is >> -means upstream will never use any downstream names for its commands, >> -arguments, errors, asynchronous events, and so forth. >> +'__' (double underscore) for downstream use ("downstream names"). Do= wnstream >> +names MUST NOT end with '__' as this pattern is reserved for QMP-defi= ned JSON >> +object classes. Upstream will never use any downstream names for its= >> +commands, arguments, errors, asynchronous events, and so forth. >=20 > Suggest mentioning subsection 2.6. OK. Thanks, Jan --------------enigA18AC760BF90F9722B5B3246 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkv+8DIACgkQitSsb3rl5xQSXQCgiCJWe3D3vNlwqCl20I74GwCq VYEAmwdFiSzqCbyPwSxOdSR0CN+xsp3i =KkQC -----END PGP SIGNATURE----- --------------enigA18AC760BF90F9722B5B3246--