From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50096 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OIOI8-0003uJ-PA
	for qemu-devel@nongnu.org; Sat, 29 May 2010 11:49:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1OIHUW-0003Sf-KV
	for qemu-devel@nongnu.org; Sat, 29 May 2010 04:34:01 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:38736)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1OIHUW-0003SM-6Y
	for qemu-devel@nongnu.org; Sat, 29 May 2010 04:34:00 -0400
Message-ID: <4C00D16F.90703@web.de>
Date: Sat, 29 May 2010 10:33:51 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH v3 13/17] monitor: Allow to exclude
	commands from QMP
References: <cover.1274612367.git.jan.kiszka@web.de>	<5d0139dc62706a1efcbb6a63d5936484ad279916.1274612367.git.jan.kiszka@web.de>	<20100527173147.304ee68b@redhat.com>
	<m3r5kvi0nc.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3r5kvi0nc.fsf@blackfin.pond.sub.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig1553C98A6B01CDBD6D2744A0"
Sender: jan.kiszka@web.de
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Juan Quintela <quintela@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>, Markus@redhat.com

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig1553C98A6B01CDBD6D2744A0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Markus Armbruster wrote:
> Luiz Capitulino <lcapitulino@redhat.com> writes:
>=20
>> On Sun, 23 May 2010 12:59:26 +0200
>> Jan Kiszka <jan.kiszka@web.de> wrote:
>>
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> Ported commands that are marked 'user_only' will not be considered fo=
r
>>> QMP monitor sessions. This allows to implement new commands that do n=
ot
>>> (yet) provide a sufficiently stable interface for QMP use (e.g.
>>> device_show).
>>  This is fine for me, but two things I've been wondering:
>>
>>  1. Isn't a 'flags' struct member better? So that we can do (in the
>>     qemu-monitor.hx entry):
>>
>>         .flags =3D MONITOR_USER_ONLY | MONITOR_HANDLER_ASYNC,
>>
>>     I'm not suggesting this is an async handler, just exemplifying mul=
tiple
>>     flags.
>=20
> We also have at least one command that makes only sense in QMP:
> qmp_capabilities.  Maybe we could use separate flags controlling comman=
d
> availability in human monitor and QMP.

Sounds reasonable. Then I think I will lay the ground for this by
introducing flags already in this patch. A v4 run is required anyway.

Jan


--------------enig1553C98A6B01CDBD6D2744A0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkwA0XQACgkQitSsb3rl5xTWkQCfdDeeg9+MqghIneOD604ncLMA
euUAn2yxRp13HaXqIiKxc2uLABetq+XZ
=d1Lv
-----END PGP SIGNATURE-----

--------------enig1553C98A6B01CDBD6D2744A0--