From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57121 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OIdh7-0000Gi-06 for qemu-devel@nongnu.org; Sun, 30 May 2010 04:16:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OIdh5-0008E9-Mu for qemu-devel@nongnu.org; Sun, 30 May 2010 04:16:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9057) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OIdh5-0008Du-DJ for qemu-devel@nongnu.org; Sun, 30 May 2010 04:16:27 -0400 Message-ID: <4C021ED5.1080703@redhat.com> Date: Sun, 30 May 2010 11:16:21 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs References: <3715da16813f7cdcb7ec023167a84a94e8a37089.1274612367.git.jan.kiszka@web.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Anthony Liguori , Juan Quintela , Jan Kiszka , qemu-devel@nongnu.org, Luiz Capitulino , Blue Swirl , Jan Kiszka On 05/29/2010 11:01 AM, Markus Armbruster wrote: > Jan Kiszka writes: > > >> From: Jan Kiszka >> >> As the user may specify ambiguous device IDs, let's search for their >> official names first before considering the user-supplied identifiers. >> >> Signed-off-by: Jan Kiszka >> > The problem is letting the user specify ambiguous device IDs in the > first place! That way is madness... > Agreed, we're sowing the seeds for future problems. -- error compiling committee.c: too many arguments to function