From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36204 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OIeYa-0001PY-O6 for qemu-devel@nongnu.org; Sun, 30 May 2010 05:11:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OIeYZ-0005nI-Sf for qemu-devel@nongnu.org; Sun, 30 May 2010 05:11:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64578) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OIeYZ-0005nA-MO for qemu-devel@nongnu.org; Sun, 30 May 2010 05:11:43 -0400 Message-ID: <4C022BCB.5000907@redhat.com> Date: Sun, 30 May 2010 12:11:39 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: RFC: blockdev_add & friends, brief rationale, QMP docs References: <4C0015E6.50805@redhat.com> <4C0016B3.6000505@codemonkey.ws> <20100528162451.2d10859d@redhat.com> In-Reply-To: <20100528162451.2d10859d@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Kevin Wolf , qemu-devel@nongnu.org, Markus Armbruster , Gerd Hoffmann On 05/28/2010 10:24 PM, Luiz Capitulino wrote: > >> If a password is needed, we should throw an error and let the QMP client >> set the password and try again. >> > It's what we do today, a password should be set with block_passwd before > issuing the change command. Otherwise an error is throw. > Is the password some kind of global or per-monitor property? In that case it doesn't work with parallel execution of commands; better to have a password field (or assign IDs to passwords and require a passwordid=... argument). -- error compiling committee.c: too many arguments to function