From: Gerd Hoffmann <kraxel@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.
Date: Mon, 31 May 2010 10:48:36 +0200 [thread overview]
Message-ID: <4C0377E4.5050502@redhat.com> (raw)
In-Reply-To: <201005281521.30359.paul@codesourcery.com>
On 05/28/10 16:21, Paul Brook wrote:
>> Try to pci hotplug a vga card, watch qemu die with hw_error().
>> This patch fixes it.
>
> I think this is wrong. There's no reason why VGA adapters shouldn't be
> hotplugged. You should fix the underlying problems that prevent hotplugging
The qemu code base simply isn't prepared for that. Making vga hotplug
requires alot of infrastructure work within qemu, see discussion with
Stefano in this thread. I'm also not fully sure it is possible to
hotplug the primary vga due to the legacy vga i/o ports.
> (or make them fail gracefully).
Make hotplug fail gracefully is exactly what the patch does because
making hotplug work is impossible short-term IMHO.
cheers,
Gerd
prev parent reply other threads:[~2010-05-31 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 8:43 [Qemu-devel] [PATCH] all vga: refuse hotplugging Gerd Hoffmann
2010-05-26 10:59 ` Stefano Stabellini
2010-05-26 11:22 ` Gerd Hoffmann
2010-05-26 11:49 ` Stefano Stabellini
2010-05-26 12:58 ` Gerd Hoffmann
2010-05-26 13:18 ` Stefano Stabellini
2010-05-26 13:39 ` Gerd Hoffmann
2010-05-28 14:21 ` Paul Brook
2010-05-31 8:48 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0377E4.5050502@redhat.com \
--to=kraxel@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).