From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45061 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJ0mM-0001pK-Vr for qemu-devel@nongnu.org; Mon, 31 May 2010 04:55:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJ0gA-0006ex-RY for qemu-devel@nongnu.org; Mon, 31 May 2010 04:49:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13793) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJ0gA-0006el-KU for qemu-devel@nongnu.org; Mon, 31 May 2010 04:49:02 -0400 Message-ID: <4C0377E4.5050502@redhat.com> Date: Mon, 31 May 2010 10:48:36 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging. References: <1274863397-15005-1-git-send-email-kraxel@redhat.com> <201005281521.30359.paul@codesourcery.com> In-Reply-To: <201005281521.30359.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On 05/28/10 16:21, Paul Brook wrote: >> Try to pci hotplug a vga card, watch qemu die with hw_error(). >> This patch fixes it. > > I think this is wrong. There's no reason why VGA adapters shouldn't be > hotplugged. You should fix the underlying problems that prevent hotplugging The qemu code base simply isn't prepared for that. Making vga hotplug requires alot of infrastructure work within qemu, see discussion with Stefano in this thread. I'm also not fully sure it is possible to hotplug the primary vga due to the legacy vga i/o ports. > (or make them fail gracefully). Make hotplug fail gracefully is exactly what the patch does because making hotplug work is impossible short-term IMHO. cheers, Gerd