From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50324 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OJ2uN-0002Pl-4q
	for qemu-devel@nongnu.org; Mon, 31 May 2010 07:11:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OJ2uL-0000n1-5s
	for qemu-devel@nongnu.org; Mon, 31 May 2010 07:11:51 -0400
Received: from goliath.siemens.de ([192.35.17.28]:16647)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OJ2uK-0000ma-SJ
	for qemu-devel@nongnu.org; Mon, 31 May 2010 07:11:49 -0400
Message-ID: <4C039970.7000302@siemens.com>
Date: Mon, 31 May 2010 13:11:44 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state
	visualization
References: <cover.1274516288.git.jan.kiszka@web.de>	<1f557b9feb1965a61e64f7166bcf4918bed8d0ec.1274516288.git.jan.kiszka@web.de>	<4BF82895.6000706@redhat.com>
	<4BF8DFF7.5070302@web.de>	<4BF8EAFB.2080807@redhat.com>
	<m3bpbzjfxw.fsf@blackfin.pond.sub.org>	<4C00CCD4.7050904@web.de>
	<4C02212A.6060702@redhat.com>	<4C025BC7.8070600@web.de>
	<m3fx188nmb.fsf@blackfin.pond.sub.org>	<4C037A3D.5090403@siemens.com>
	<m3ljb049el.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3ljb049el.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Juan Quintela <quintela@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>, Jan Kiszka <jan.kiszka@web.de>, Avi Kivity <avi@redhat.com>

Markus Armbruster wrote:
> Jan Kiszka <jan.kiszka@siemens.com> writes:
> 
>> Markus Armbruster wrote:
>>> Jan Kiszka <jan.kiszka@web.de> writes:
>>>
>>>> Avi Kivity wrote:
>>>>> On 05/29/2010 11:14 AM, Jan Kiszka wrote:
>>>>>>> Currently breaks down when IDs contain '/', but permitting that is a
>>>>>>> bug.  There may be more problems; the path lookup code is way too
>>>>>>> clever.
>>>>>>>      
>>>>>> Indeed. Less can sometimes be more. My impression is that some of the
>>>>>> cleverness was motivated by lacking qtree completion for the HMP.
>>>>>>    
>>>>> Can we disable abbreviations for QMP and only allow them for HMP?
>>>>>
>>>>> We can support that by adding a hidden argument to commands specifying
>>>>> whether the input comes from a human or machine.  Abbreviations are
>>>>> dangerous if they become ambiguous; a human can recover while a machine
>>>>> can't.
>>>>>
>>>> Both QMP _and_ HMP suffer from ambitious and inconsistent addressing
>>>> schemes. Therefore, I'm more and more in favor of [1]. We just need to
>>>> add command line completion for option values, something that would be
>>>> beneficial for 'drive_add file=...' as well.
>>>>
>>>> Jan
>>>>
>>>> [1] http://article.gmane.org/gmane.comp.emulators.qemu/72152
>>> [1] = abolish the clever abbreviations in path lookup.  I agree we
>>> should do that.
>> Fine. No concerns regarding overlaying IDs and path specifications as well?
> 
> I'm fine with that.
> 
> Calling the overlayed argument "id" is not so nice.  We got a bunch of
> other not-so-nice names in QMP, maybe we'll have a flag day to clean
> them all up.

For this case (device_del and device_show), I think we should simply
call it 'device'.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux