* [Qemu-devel] [PATCH] target-ppc: remove useless line
@ 2010-05-28 19:00 Thomas Monjalon
2010-05-29 13:31 ` Andreas Färber
2010-05-31 18:45 ` Aurelien Jarno
0 siblings, 2 replies; 6+ messages in thread
From: Thomas Monjalon @ 2010-05-28 19:00 UTC (permalink / raw)
To: qemu-devel
From: Thomas Monjalon <thomas@monjalon.net>
This line was a bit clear.
The next lines set or reset this bit (LE) depending of another bit (ILE).
So the first line is useless.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
target-ppc/helper.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/target-ppc/helper.c b/target-ppc/helper.c
index 3d843b5..dabf1fd 100644
--- a/target-ppc/helper.c
+++ b/target-ppc/helper.c
@@ -2591,7 +2591,6 @@ static inline void powerpc_excp(CPUState *env, int excp_model, int excp)
#if 0 /* Fix this: not on all targets */
new_msr &= ~((target_ulong)1 << MSR_PMM);
#endif
- new_msr &= ~((target_ulong)1 << MSR_LE);
if (msr_ile)
new_msr |= (target_ulong)1 << MSR_LE;
else
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] target-ppc: remove useless line
2010-05-28 19:00 [Qemu-devel] [PATCH] target-ppc: remove useless line Thomas Monjalon
@ 2010-05-29 13:31 ` Andreas Färber
2010-05-31 9:49 ` Alexander Graf
2010-05-31 18:45 ` Aurelien Jarno
1 sibling, 1 reply; 6+ messages in thread
From: Andreas Färber @ 2010-05-29 13:31 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: qemu-devel Developers, Alexander Graf
Am 28.05.2010 um 21:00 schrieb Thomas Monjalon:
> From: Thomas Monjalon <thomas@monjalon.net>
>
> This line was a bit clear.
> The next lines set or reset this bit (LE) depending of another bit
> (ILE).
> So the first line is useless.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> target-ppc/helper.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/target-ppc/helper.c b/target-ppc/helper.c
> index 3d843b5..dabf1fd 100644
> --- a/target-ppc/helper.c
> +++ b/target-ppc/helper.c
> @@ -2591,7 +2591,6 @@ static inline void powerpc_excp(CPUState *env,
> int excp_model, int excp)
> #if 0 /* Fix this: not on all targets */
> new_msr &= ~((target_ulong)1 << MSR_PMM);
> #endif
> - new_msr &= ~((target_ulong)1 << MSR_LE);
> if (msr_ile)
> new_msr |= (target_ulong)1 << MSR_LE;
> else
Following line is
new_msr &= ~((target_ulong)1 << MSR_LE);
so this should be fine.
Reviewed-by: Andreas Faerber <andreas.faerber@web.de>
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] target-ppc: remove useless line
2010-05-29 13:31 ` Andreas Färber
@ 2010-05-31 9:49 ` Alexander Graf
2010-05-31 13:11 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Graf @ 2010-05-31 9:49 UTC (permalink / raw)
To: Andreas Färber; +Cc: qemu-devel Developers
On 29.05.2010, at 15:31, Andreas Färber wrote:
> Am 28.05.2010 um 21:00 schrieb Thomas Monjalon:
>
>> From: Thomas Monjalon <thomas@monjalon.net>
>>
>> This line was a bit clear.
>> The next lines set or reset this bit (LE) depending of another bit (ILE).
>> So the first line is useless.
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>> ---
>> target-ppc/helper.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/target-ppc/helper.c b/target-ppc/helper.c
>> index 3d843b5..dabf1fd 100644
>> --- a/target-ppc/helper.c
>> +++ b/target-ppc/helper.c
>> @@ -2591,7 +2591,6 @@ static inline void powerpc_excp(CPUState *env, int excp_model, int excp)
>> #if 0 /* Fix this: not on all targets */
>> new_msr &= ~((target_ulong)1 << MSR_PMM);
>> #endif
>> - new_msr &= ~((target_ulong)1 << MSR_LE);
>> if (msr_ile)
>> new_msr |= (target_ulong)1 << MSR_LE;
>> else
>
> Following line is
> new_msr &= ~((target_ulong)1 << MSR_LE);
> so this should be fine.
>
> Reviewed-by: Andreas Faerber <andreas.faerber@web.de>
Thomas, have you verified that it still boots a ppc64 guest?
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] target-ppc: remove useless line
2010-05-31 9:49 ` Alexander Graf
@ 2010-05-31 13:11 ` Thomas Monjalon
2010-05-31 14:59 ` Alexander Graf
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2010-05-31 13:11 UTC (permalink / raw)
To: Alexander Graf; +Cc: Andreas Färber, qemu-devel Developers
Alexander Graf wrote:
> Thomas, have you verified that it still boots a ppc64 guest?
No, but I don't see any specific link between ppc64 and this change.
This is the current (pseudo)code:
LE = 0
if ILE == 1
LE = 1
else
LE = 0
In all cases, LE will be overwritten after the first line.
I cannot see any justification to keep the first line.
--
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] target-ppc: remove useless line
2010-05-31 13:11 ` Thomas Monjalon
@ 2010-05-31 14:59 ` Alexander Graf
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Graf @ 2010-05-31 14:59 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: Andreas Färber, qemu-devel Developers
Thomas Monjalon wrote:
> Alexander Graf wrote:
>
>> Thomas, have you verified that it still boots a ppc64 guest?
>>
>
> No, but I don't see any specific link between ppc64 and this change.
>
> This is the current (pseudo)code:
> LE = 0
> if ILE == 1
> LE = 1
> else
> LE = 0
> In all cases, LE will be overwritten after the first line.
>
> I cannot see any justification to keep the first line.
>
I agree.
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] target-ppc: remove useless line
2010-05-28 19:00 [Qemu-devel] [PATCH] target-ppc: remove useless line Thomas Monjalon
2010-05-29 13:31 ` Andreas Färber
@ 2010-05-31 18:45 ` Aurelien Jarno
1 sibling, 0 replies; 6+ messages in thread
From: Aurelien Jarno @ 2010-05-31 18:45 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: qemu-devel
On Fri, May 28, 2010 at 09:00:45PM +0200, Thomas Monjalon wrote:
> From: Thomas Monjalon <thomas@monjalon.net>
>
> This line was a bit clear.
> The next lines set or reset this bit (LE) depending of another bit (ILE).
> So the first line is useless.
Thanks, applied.
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> target-ppc/helper.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/target-ppc/helper.c b/target-ppc/helper.c
> index 3d843b5..dabf1fd 100644
> --- a/target-ppc/helper.c
> +++ b/target-ppc/helper.c
> @@ -2591,7 +2591,6 @@ static inline void powerpc_excp(CPUState *env, int excp_model, int excp)
> #if 0 /* Fix this: not on all targets */
> new_msr &= ~((target_ulong)1 << MSR_PMM);
> #endif
> - new_msr &= ~((target_ulong)1 << MSR_LE);
> if (msr_ile)
> new_msr |= (target_ulong)1 << MSR_LE;
> else
> --
> 1.7.1
>
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-05-31 18:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-28 19:00 [Qemu-devel] [PATCH] target-ppc: remove useless line Thomas Monjalon
2010-05-29 13:31 ` Andreas Färber
2010-05-31 9:49 ` Alexander Graf
2010-05-31 13:11 ` Thomas Monjalon
2010-05-31 14:59 ` Alexander Graf
2010-05-31 18:45 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).