From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47290 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJA46-0003x8-MK for qemu-devel@nongnu.org; Mon, 31 May 2010 14:50:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJ9sL-0002Qo-IU for qemu-devel@nongnu.org; Mon, 31 May 2010 14:38:16 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49824 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJ9sL-0002Qf-DP for qemu-devel@nongnu.org; Mon, 31 May 2010 14:38:13 -0400 Message-ID: <4C040212.2060802@suse.de> Date: Mon, 31 May 2010 20:38:10 +0200 From: Alexander Graf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Fix leul_to_cpu on big endian hosts References: <1273592297-18370-1-git-send-email-agraf@suse.de> In-Reply-To: <1273592297-18370-1-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Marcelo Tosatti , Aurelien Jarno Alexander Graf wrote: > Commit 213acd2e introduced leul_to_cpu with a special code path for big endian > hosts. Unfortunately that code used preprocessor magic that didn't work. > > This patch replaces the explicit ##s by glue() which is proven to work reliably, > enabling me to compile qemu on ppc again. > Ping? Alex